1572364 - Make jsrust_shared a non-optional dependency of gkrust-shared

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task)

Description

[Henri Sivonen (:hsivonen)]

jsrust_shared is now optional in gkrust-shared:
https://searchfox.org/mozilla-central/rev/e0b0c38ee83f99d3cf868bad525ace4a395039f1/toolkit/library/rust/shared/Cargo.toml#36

Since Rust isn't optional for Firefox as a whole, avoiding jsrust_shared under some circumstances as part of a full Firefox build doesn't really buy us anything. Let's make it a non-optional dependency of gkrust-shared to be able move some FFI crates from under gkrust-shared to under jsrust_shared while Firefox as a whole being able to rely on those FFI crates not being optional for the purpose of a full Firefox build.

(Making Rust non-optional for standalone SpiderMonkey is out of scope for this bug.)

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1572364 - Make jsrust_shared a non-optional dependency of gkrust-shared.

Comment 2

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=aeb25c604b9a412984dfb10f42bfebc3af3faf53

Not sure if I should have enabled more tasks on try to get the right build config coverage. However, locally, it appears that both Firefox itself and standalone SpiderMonkey still built with both --enable-cranelift and --disable-cranelift.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6db54eb9e2f7
Make jsrust_shared a non-optional dependency of gkrust-shared. r=bbouvier

Comment 4

[Henri Sivonen (:hsivonen)]

Filed bug 1573098 as a follow-up.

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6db54eb9e2f7