Closed Bug 1573098 Opened 2 years ago Closed 2 years ago

Make non-Firefox builds of SpiderMonkey build jsrust unconditionally

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: hsivonen, Assigned: bbouvier)

References

Details

Attachments

(1 file)

Bug 1572364 made jsrust_shared part of the Firefox build regardless of whether Cranelift is enabled or not to enable making encoding_c_mem (see bug 1490601) available to SpiderMonkey without FFI symbol duplication with gkrust_shared. To enable building encoding_c_mem or other future non-Cranelift Rust code as part of a non-Firefox SpiderMonkey build even when Cranelift is not enabled, non-Firefox SpiderMonkey builds should build and link jsrust and jsrust_shared unconditionally instead of only when Cranelift is enabled.

Benjamin, can you take a look at this when you have a moment?

Flags: needinfo?(bbouvier)

More of a JS::General component I guess. Who does build systems work on the JS engine?

Component: Javascript: WebAssembly → JavaScript Engine
Flags: needinfo?(sphink)
Flags: needinfo?(bbouvier)
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Flags: needinfo?(sphink)
Priority: -- → P1
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61d898c2b444
Build Spidermonkey Rust's library unconditionally; r=froydnj
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Regressions: 1575769
You need to log in before you can comment on or make changes to this bug.