1573098 - Make non-Firefox builds of SpiderMonkey build jsrust unconditionally

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Henri Sivonen (:hsivonen)]

Bug 1572364 made jsrust_shared part of the Firefox build regardless of whether Cranelift is enabled or not to enable making encoding_c_mem (see bug 1490601) available to SpiderMonkey without FFI symbol duplication with gkrust_shared. To enable building encoding_c_mem or other future non-Cranelift Rust code as part of a non-Firefox SpiderMonkey build even when Cranelift is not enabled, non-Firefox SpiderMonkey builds should build and link jsrust and jsrust_shared unconditionally instead of only when Cranelift is enabled.

Comment 1

[Lars T Hansen [:lth]]

Benjamin, can you take a look at this when you have a moment?

Comment 2

[Lars T Hansen [:lth]]

More of a JS::General component I guess. Who does build systems work on the JS engine?

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Well, I've got a simple patch, let's see if it works...
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3dce81dc3ed715f6f6280836e17a49c88110be1

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1573098: Build Spidermonkey Rust's library unconditionally; r?firefox-build-system-reviewers

Comment 5

[Hassan Lukosi Kibiti [:elimuhub]]

resolve bug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61d898c2b444
Build Spidermonkey Rust's library unconditionally; r=froydnj

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/61d898c2b444