1572416 - [Protections Panel] If the info message is open when navigating to a sub-panel, the header inflates abnormally after navigating back and closing the message

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

STR:

1. Open the Protections Popup and ensure the info message is shown by clicking the "i" icon if necessary
2. Navigate into a sub-panel (for example, click the "Site not working?" link)
3. Navigate back to the main view
4. Close the info message by clicking the "i" icon.

Expected: The popup shrinks to compensate for the now-hidden info message space
Actual: The panel header expands to fill the space and the popup height remains constanst

The reason for this is that when navigating to a sub-panel, PanelMultiView sets a min-height matching the current popup height on the .panel-viewcontainer box to ensure the panel doesn't shrink upon navigation. After navigating back to the main view, this style is never cleared, resulting in the popup trying to maintain that min-height when its contents change.

The solution could be for PanelMultiView to clear this min-height when navigating back to the main view. This would also be a good opportunity to fire an event or set an attribute indicating we are in the main view, which would help solve bug 1563093.

Gijs and Mike, could you help me figure out the best way to do this? I think PanelMultiView should give consumers a way to know that the panel is currently on the main view, for styling etc.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1572416 - PanelMultiView: remove the min-height on the view container when navigating to the main view. r=johannh

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Clearing needinfo, I think I figured out a solution that doesn't need more information.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e135f0379062
PanelMultiView: remove the min-height on the view container when navigating to the main view. r=johannh

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e135f0379062