1572455 - [Wayland] [CSD] When restoring minimized window the tabs stop to redraw

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Jan Horak [:jhorak]]

Also after window restore from minimized state the window state is kept as minimized, subsequent minimize button does not work.

This is because the GTK does not send the GDK_WINDOW_STATE_ICONIFIED state to the window_state_event_cb during iconify (under Wayland only).

Upstream bug: https://gitlab.gnome.org/GNOME/gtk/issues/67

Comment 1

[Jan Horak [:jhorak]]

Attachment: Bug 1572455 Workaround for restoring minimized window in Wayland; r=stransky

Under Wayland the GTK does not send the correct window state event change
when the window is iconified. We need to add a workaround for that to avoid
unresponsive UI after restoring the window.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4784b03e2ffd
Workaround for restoring minimized window in Wayland; r=stransky

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4784b03e2ffd

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9084033 [details]
Bug 1572455 Workaround for restoring minimized window in Wayland; r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: Restored window on Firefox/Wayland is not visible.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Linux/Wayland only fix.
• String changes made/needed: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9084033 [details]
Bug 1572455 Workaround for restoring minimized window in Wayland; r=stransky

Fixes a bug with Wayland on Linux. Approved for 69.0b16.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ae05305802d3