1572487 - Add UI Test for STP Pref with Preferences

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Maxx Crawford [:maxx]]

Add UI Test for UI Additions within about:preferences#privacy section

Comment 1

[Maxx Crawford [:maxx]]

What specifically should this test cover? To make sure the "Social Media Trackers" line item appears in the Content Blocking options approraitely? Or does this address all UI within the preferecnes#privacy panel?

Comment 2

[Johann Hofmann [:johannh]]

No, we already have existing tests for the content blocking section. You should make sure that the functionality you added is covered by those tests, where possible.

What I could think of right now would be:

• Add all social blocking settings to the browser_contentblocking_categories.js test.
• Ensure that toggling privacy.socialtracking.block_cookies.enabled hides the social blocking UI

That should give us decent test coverage, I think :)

Thanks!

Comment 3

[Maxx Crawford [:maxx]]

For the #1571531 patch, I'll add that test to this function.

Comment 4

[Maxx Crawford [:maxx]]

Attachment: Bug 1572487 - Add UI Test for STP Pref with Preferences r?johannh

Comment 5

[Maxx Crawford [:maxx]]

Added the test for the Custom Tracking Content UI! Ready for review.

Comment 6

[Johann Hofmann [:johannh]]

Awesome, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b66659692980
Add UI Test for STP Pref with Preferences r=johannh

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b66659692980