1566861 - Revise Tracking Protection Panel UI in Preferences

Status: RESOLVED FIXED

(Firefox :: Protections UI, enhancement, P1)

Description

[Maxx Crawford [:maxx]]

• Update mulitple text strings in Enhanced Tracking Protection panel
• Add additional icons/revise order of strings in panel UI

Documentation Links:
UX: https://mozilla.invisionapp.com/share/QWT0UQ5APET#/371154741_Preferences
Strings: https://docs.google.com/presentation/d/14-AIQWnDDHO1pYhHDZffJ2x4gWT7VkCSkb-X3ghmfKA

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1566861 - Revise Tracking Protection Panel UI in Preferences r=johannh

Comment 2

[Maxx Crawford [:maxx]]

Removed this portion of the bug:

Hide "Change Block List" ui in Custom option of ETP behind pref: browser.contentblocking.customBlockList.preferences.ui.enabled;true

Moved to https://bugzilla.mozilla.org/show_bug.cgi?id=1568900

Comment 3

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f73b4b4963c7a7561ff8ce1de8abebc16e0d9306

Comment 4

[Tanvi Vyas[:tanvi]]

A few notes:

• In the Standard category, show the item for "Social Media Trackers" if privacy.trackingprotection.socialtracking.annotate.enabled is set to true.
• In the Strict category, show the item for "Social Media Trackers" if privacy.trackingprotection.socialtracking.annotate.enabled is set to true.
• To enable cookie blocking for social trackers, privacy.socialtracking.block_cookies.enabled will be set to true by default. If a user selects custom, and changes their cookie settings from "Cross-site tracking and social media cookies", then we should set this pref to false.
• If the user has selected Strict, then turn on privacy.trackingprotection.socialtracking.enabled.
• If the user has selected Custom->Trackers->In all windows, turn on privacy.trackingprotection.socialtracking.enabled.

Does the patch already do these things? Please comment on the behavior and we can make any necessary changes in followup bugs.
We may also need to update browser.contentblocking.features.strict to include "stp". Erica, what do you think about that?

Comment 5

[Maxx Crawford [:maxx]]

(In reply to Tanvi Vyas[:tanvi] from comment #4)

The following are all hidden behind privacy.trackingprotection.socialtracking.annotate.enabled and are visible when set to true:

• Social Media Trackers in Standard / Strict
• Custom Cookie Settings Dropdown "Cross-site tracking and social media cookies"

This patch ONLY applies to UI adjustments. There are no changes to the blocking of social sites. The last two bullets are not related to this patch, and need to be confirmed.

Comment 6

[Erica Wright [:ewright]]

(In reply to Tanvi Vyas[:tanvi] from comment #4)
We'll need to add "stp" to strict, then add the privacy.trackingprotection.socialtracking.annotate.enabled pref to this.CATEGORY_PREFS and add a case for it here

Comment 7

[Maxx Crawford [:maxx]]

Updated try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc4ab862a28a58980240b07d5040e6e7cadc94a0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aee1f1d976c
Revise Tracking Protection Panel UI in Preferences r=fluent-reviewers,Pike,johannh

Comment 9

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 2aee1f1d976c (bug 1566861) for browser-chrome failures at browser/base/content/test/static/browser_all_files_referenced.js

Backout: https://hg.mozilla.org/integration/autoland/rev/56f1c824cf952ea281320ff65a368bb9ea9933c2

Autoland failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=260642901&revision=2aee1f1d976cecd7ada04135298b2a0a4e803770

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=260642901&repo=autoland&lineNumber=1806

[task 2019-08-08T19:00:32.064Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/Http.jsm used from resource://app/modules/translation/GoogleTranslator.jsm,resource://app/modules/translation/YandexTranslator.jsm,resource://app/modules/translation/BingTranslator.jsm
[task 2019-08-08T19:00:32.065Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Utils.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/AccessFu.jsm,resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-08-08T19:00:32.066Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/SyncedBookmarksMirror.jsm used from resource://services-sync/engines/bookmarks.js
[task 2019-08-08T19:00:32.066Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Constants.jsm used from chrome://global/content/accessibility/content-script.js,resource://gre/modules/accessibility/Traversal.jsm,resource://gre/modules/accessibility/EventManager.jsm,resource://gre/modules/accessibility/Utils.jsm,resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-08-08T19:00:32.067Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/ContentControl.jsm used from chrome://global/content/accessibility/content-script.js
[task 2019-08-08T19:00:32.068Z] 19:00:32 INFO - indirectly whitelisted file: chrome://passwordmgr/content/recipes.json used from resource://gre/greprefs.js
[task 2019-08-08T19:00:32.070Z] 19:00:32 INFO - indirectly whitelisted file: resource://formautofill/FormAutofillSync.jsm used from resource://services-sync/service.js
[task 2019-08-08T19:00:32.071Z] 19:00:32 INFO - indirectly whitelisted file: chrome://global/locale/AccessFu.properties used from resource://gre/modules/accessibility/Utils.jsm
[task 2019-08-08T19:00:32.071Z] 19:00:32 INFO - indirectly whitelisted file: resource://services-sync/bookmark_repair.js used from resource://services-sync/collection_repair.js
[task 2019-08-08T19:00:32.072Z] 19:00:32 INFO - indirectly whitelisted file: resource://services-sync/doctor.js used from resource://services-sync/bookmark_repair.js,resource://services-sync/stages/enginesync.js
[task 2019-08-08T19:00:32.072Z] 19:00:32 INFO - indirectly whitelisted file: resource://gre/modules/accessibility/Traversal.jsm used from resource://gre/modules/accessibility/ContentControl.jsm
[task 2019-08-08T19:00:32.073Z] 19:00:32 INFO - Buffered messages finished
[task 2019-08-08T19:00:32.073Z] 19:00:32 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
[task 2019-08-08T19:00:32.073Z] 19:00:32 INFO - Stack trace:
[task 2019-08-08T19:00:32.073Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:test_is:1591
[task 2019-08-08T19:00:32.074Z] 19:00:32 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:941
[task 2019-08-08T19:00:32.074Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
[task 2019-08-08T19:00:32.074Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
[task 2019-08-08T19:00:32.075Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-08-08T19:00:32.075Z] 19:00:32 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-08-08T19:00:32.075Z] 19:00:32 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-08-08T19:00:32.076Z] 19:00:32 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/skin/controlcenter/trackers-disabled.svg -
[task 2019-08-08T19:00:32.076Z] 19:00:32 INFO - Stack trace:
[task 2019-08-08T19:00:32.077Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:test_ok:1576
[task 2019-08-08T19:00:32.077Z] 19:00:32 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:945
[task 2019-08-08T19:00:32.077Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1346
[task 2019-08-08T19:00:32.078Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1381
[task 2019-08-08T19:00:32.078Z] 19:00:32 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1209
[task 2019-08-08T19:00:32.078Z] 19:00:32 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-08-08T19:00:32.079Z] 19:00:32 INFO - ignored unused whitelist entry: resource://app/blocklist.xml
[task 2019-08-08T19:00:32.080Z] 19:00:32 INFO - ignored unused whitelist entry: resource://gre/gmp-clearkey/0.1/manifest.json
[task 2019-08-08T19:00:32.080Z] 19:00:32 INFO - ignored unused whitelist entry: resource://gre/res/test.properties
[task 2019-08-08T19:00:32.081Z] 19:00:32 INFO - ignored unused whitelist entry: resource://app/localization/en-US/browser/aboutConfig.ftl

Comment 10

[Johann Hofmann [:johannh]]

Hey Maxx, you need to remove this icon to make the test happy: https://searchfox.org/mozilla-central/source/browser/themes/shared/controlcenter/trackers-disabled.svg

Once that's done you can just set checkin-needed again, no review necessary for that.

Thanks!

Comment 11

[Maxx Crawford [:maxx]]

Removed the file, along with its reference in the browser/themes/shared/jar.inc.mn file. Updating patch now!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80b225468e0a
Revise Tracking Protection Panel UI in Preferences r=fluent-reviewers,Pike,johannh

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/80b225468e0a