Closed Bug 1572618 Opened 6 years ago Closed 4 years ago

Allow rlbox Wasm library sandboxes to be linked statically

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(firefox95 fixed)

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: shravanrn, Assigned: shravanrn, Mentored)

References

(Blocks 1 open bug)

Details

Crash Data

Attachments

(1 file, 1 obsolete file)

No description provided.
Depends on: 1735455

We still rely on dynamic loading to find the symbols, but since we get
them from libxul, we don't need to load the library before activating
the process sandbox anymore.

Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/0a70349bb19a Statically link the rlbox library to libxul. r=firefox-build-system-reviewers,nika,andi
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/95c98eb80002 adjust Thunderbird package-manifest.in for "Allow rlbox Wasm library sandboxes to be linked statically". rs=me

I believe this is now backed out

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

I believe this is now backed out

No it's not.

Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED

ah sorry for the confusion. You are correct.
TLDR - This bug tracks the moving of wasm-compiled code into xul, which landed. A separate bug will track the static function invocation change.

Comment on attachment 9246081 [details]
Bug 1572618 - Allow rlbox Wasm library sandboxes to be linked statically r=glandium

Revision D128566 was moved to bug 1737733. Setting attachment 9246081 [details] to obsolete.

Attachment #9246081 - Attachment is obsolete: true
Crash Signature: [@ abort | rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox]
Crash Signature: [@ abort | rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox] → [@ abort | rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox ]
Crash Signature: [@ abort | rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox ] → [@ abort | rlbox::rlbox_wasm2c_sandbox::impl_create_sandbox]
Blocks: 1758626
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: