1572641 - More accessibility fix-ups for screen readers

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Marco Zehe (:MarcoZ)]

Very recent landings introduced a number of new issues, see bug 1572564 for the visual ones. Also, this panel now screams to be browseable via screen reader reading/browse mode commands. So, to address these:

1. All of the panels should be role "document", not just some of them. There is enough information in here that is in textual form only, not part of a control, that it makes sense to give screen reader users the ability to browse through them with their familiar reading commands.
2. Consequently, make some of the labels ARIA headings so they can be navigated to more easily.
3. The new more-info button is missing an accessible (localizable) label.

Patches in the works.

Comment 1

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1572641 Part 1: Make all of the privacy panel sub panels browseable documents for screen readers, r=johannh

Comment 2

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1572641 Part 2: Make some of the section headers into headings for screen readers, r=johannh

Depends on D41349

Comment 3

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1572641 Part 3: Associate the labels to their text inputs in the Report Site Not Working panel, r=johannh

Depends on D41350

Comment 4

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1572641 Part 4: Give the More Info button a label for screen readers, r=johannh

Depends on D41351

Comment 5

[Marco Zehe (:MarcoZ)]

While working on this, found a bug in the core accessibility engine that label associations don't generate the accessible name, although the association itself does work, e. g. clicking the label sets focus to the input or textarea.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a90563d008f4
Part 1: Make all of the privacy panel sub panels browseable documents for screen readers, r=johannh
https://hg.mozilla.org/integration/autoland/rev/526168f22912
Part 2: Make some of the section headers into headings for screen readers, r=johannh
https://hg.mozilla.org/integration/autoland/rev/84c3e4feee7b
Part 3: Associate the labels to their text inputs in the Report Site Not Working panel, r=johannh
https://hg.mozilla.org/integration/autoland/rev/2aa913a0c7ee
Part 4: Give the More Info button a label for screen readers, r=johannh

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a90563d008f4
https://hg.mozilla.org/mozilla-central/rev/526168f22912
https://hg.mozilla.org/mozilla-central/rev/84c3e4feee7b
https://hg.mozilla.org/mozilla-central/rev/2aa913a0c7ee