Multi-proxy Browser Console can't be re-opened
Categories
(DevTools :: Console, defect, P1)
Tracking
(firefox70 verified)
Tracking | Status | |
---|---|---|
firefox70 | --- | verified |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission dt-fission-m1)
Attachments
(1 file)
Bug 1572671 - Don't load content process server startup script if it was already loaded. r=ochameau.
47 bytes,
text/x-phabricator-request
|
Details | Review |
Steps to reproduce
- Open the Browser console with the browser toolbox fission pref
- Close it
- Re-open it
Actual results
The Browser Console is blank
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Previously, we were simply having a flag on the ContentProcessConnector
that we would flip once we loaded the content process server startup script.
This was working fine until multi-proxy browser console.
Each time we open the Browser Console, we create a new loader in a new
compartment. Which means in the end we'll have a new ContentProcessConnector
instance, and the flag would be resetted, and thus we would load a new
content process server startup script, which finally, would emit some
packet twice, and thus would break how we manage new packet in the client.
This patch fixes that by replacing the flag by checking if the script
was already loaded. Since we don't need the flag and the ContentProcessConnector
object only holds a function, we directly turn the object into a function.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a111ae683fa Don't load content process server startup script if it was already loaded. r=ochameau.
Comment 3•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Comment 4•1 year ago
|
||
With devtools.browsertoolbox.fission set on true managed to confirm the issue on Windows 10 with 70.0a1 (2019-08-19).
Fix verified with 70.b7 on Windows 10, macOS 10.13, Ubuntu 16.04.
Updated•1 year ago
|
Description
•