1572671 - Multi-proxy Browser Console can't be re-opened

Status: VERIFIED FIXED

(DevTools :: Console, defect, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the Browser console with the browser toolbox fission pref
2. Close it
3. Re-open it

Actual results

The Browser Console is blank

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1572671 - Don't load content process server startup script if it was already loaded. r=ochameau.

Previously, we were simply having a flag on the ContentProcessConnector
that we would flip once we loaded the content process server startup script.
This was working fine until multi-proxy browser console.
Each time we open the Browser Console, we create a new loader in a new
compartment. Which means in the end we'll have a new ContentProcessConnector
instance, and the flag would be resetted, and thus we would load a new
content process server startup script, which finally, would emit some
packet twice, and thus would break how we manage new packet in the client.

This patch fixes that by replacing the flag by checking if the script
was already loaded. Since we don't need the flag and the ContentProcessConnector
object only holds a function, we directly turn the object into a function.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a111ae683fa
Don't load content process server startup script if it was already loaded. r=ochameau.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9a111ae683fa

Comment 4

[Cristian Fogel, QA [:cfogel]]

With devtools.browsertoolbox.fission set on true managed to confirm the issue on Windows 10 with 70.0a1 (2019-08-19).
Fix verified with 70.b7 on Windows 10, macOS 10.13, Ubuntu 16.04.