1572679 - The Show/Hide Password button is not displayed inside the Password field.

Status: RESOLVED WONTFIX

(Firefox :: about:logins, defect, P3)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: Show_Hide_button.png

[Affected versions]:

• Firefox latest Nightly 70.0a1 (2019-08-08) (64-bit)

[Affected Platforms]:

• Mac 10.14
• Windows 10 x64
• Ubuntu 18.04 x64

[Steps to reproduce]:

1. Open the browser and navigate to the "about:logins" page.
2. Click on the “Create New Login” button.
3. Observe the Show/Hide Password button.

[Expected result]:

• The Show/Hide Password button is displayed inside the Password field when typing a character.

[Actual result]:

• The Show/Hide Password button is displayed outside of the Password field.

[Notes]:

• The Show/Hide button from the about:logins page should be displayed inside the Password field on the “Create New Login” and “Edit” mode, as shown in https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931541
• On the “Create New Login” mode, the Show/Hide Password button is clickable when the field is empty.
• Attached a screenshot with the issue.

Comment 2

[Matthew N. [:MattN]]

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Comment 3

[ineuw]

Attachment: fireefox eye missing.jpg

This is the display when I tried to log in through add-ons. The password reveal option does not reveal itself unless I start typing., or does not reveal itself at all.

Comment 4

[:glob ✱]

The content of attachment 9160835 [details] has been deleted for the following reason:

Deleted at the request of the uploader.

Comment 5

[ineuw]

Attachment: fireefox reveal password missing.jpg

Comment 6

[ragimeg698]

The key to copy links is broken. It was broken in 88 and remains unfixed.

Copying links is a core function of a web browser. It is completely unreasonable that this function should be removed. Tens, maybe hundreds of millions of people use hotkeys. It is an absolutely normal, absolutely acceptable way to interface with a computer. All of those people have had to find solutions outside of Firefox, and for absolutely no reason.

A "replacement" key that is not physically usable is obviously not a replacement.

Since my legitimate reports about this critical bug are being removed, I'm leaving comments on other people's bugs.

---

Comment 7

[Janvi Bajoria [:janvi01]]

Hey, I would like to work on this.

Comment 8

[Janvi Bajoria [:janvi01]]

The Show/hide button should be displayed inside the field and should only be visible when we start typing for password.

Comment 9

[Janvi Bajoria [:janvi01]]

Attachment: Bug 1572679 - display show/hide password button inside password field r?sgalich

Comment 10

[Sergey Galich [:serg]]

This bug is not relevant anymore in light of Bug 1750072 and associated bugs.
There is a new, built-in reveal button coming to <input type=password> and we are planning to remove custom reveal implementation.