1572786 - Remove the Gecko profiler add-on and migrate to the profiler popup

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), task, P2)

Description

[Greg Tatum [:gregtatum]]

Right now we need to wrap up a few dependent bugs before we can turn it on for everyone. From a discussion on Slack we'll probably use the UI migration code.

https://searchfox.org/mozilla-central/rev/9775cca0a10a9b5c5f4e15c8f7b3eff5bf91bbd0/browser/components/BrowserGlue.jsm#2689

We can use the AddonManager to check for the existence of the gecko profiler add-on.

Then we can add it.

(await AddonManager.getAllAddons()).find(({id}) => id === "[e-mail]").uninstall()

I'm not sure if we need some additional UI to display to the user explaining what happened, or if swapping things out is sufficient.

Comment 1

[Greg Tatum [:gregtatum]]

Here is the workflow for migrating users:

• Check if the add-on is installed
• If it is, uninstall it, and enable the popup.
• Open up a tab with something like profiler.firefox.com/migration with a message explaining what we just did.

Comment 3

[Greg Tatum [:gregtatum]]

Attachment: Bug 1572786 - Remove the Gecko profiler add-on and migrate to the profiler popup; r?canaltinova

This patch adds an upgrader to remove the Gecko Profiler Addon if
it is installed. If the addon was also enabled, it adds the profiler
menu button to the navbar.

Depends on D66785

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6afede62221b
Remove the Gecko profiler add-on and migrate to the profiler popup; r=canaltinova

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1572786, bug 1621022) for causing mochitest failures at widget/tests/test_keycodes.xhtml

Backout: https://hg.mozilla.org/integration/autoland/rev/e21ee3abca8a78858f2c60a13c44b54a1d846d6d

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6afede62221bedc244fa1099d4fdeea62955985f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=293708898&repo=autoland&lineNumber=12639

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e86e00c78134
Remove the Gecko profiler add-on and migrate to the profiler popup; r=canaltinova

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out 2 changesets (Bug 1572786, Bug 1621022) for bc failures at browser_downloads_autohide.js.
https://hg.mozilla.org/integration/autoland/rev/9b5ef67cd556c0f9d5d2a3d17c462b93b90f41ec

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=e86e00c781340d861c9920bf85adf68a8bee635f&selectedJob=294564991

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=294564991&repo=autoland&lineNumber=15990

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4695dbc761d7
Remove the Gecko profiler add-on and migrate to the profiler popup; r=canaltinova

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4695dbc761d7