Closed Bug 1572831 Opened 1 year ago Closed 2 months ago

Fix usage of nsIDocShellTreeItem in DocAccessibleWrap::DocAccessibleWrap

Categories

(Core :: Disability Access APIs, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla73
Fission Milestone M6
Tracking Status
firefox73 --- fixed

People

(Reporter: djvj, Assigned: djvj)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

In accessible/android/DocAccessible.cpp, in the constructor for DocAccessible (https://searchfox.org/mozilla-central/source/accessible/android/DocAccessibleWrap.cpp#27):

nsIDocShellTreeItem is queried for it's parent. The logic then checks to see if the parent is null, or if the parent's ItemType is chrome when the current treenode is content. In this case, it assigns 'kNoId' to the mId field.

It's possible under post-fission behaviour that GetInProcessParent() returns null when the parent is out-of-process. This might lead to erroneously assining kNoId for a tree-item that has a valid out-of-process content parent.

The logic in the conditional should be adjusted to use BrowsingContext to check if an OOP parent exists, and if so query its ItemType.

No longer depends on: rm-docshell-tree-item
Component: DOM: Core & HTML → Disability Access APIs
Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:simple]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → kvijayan
Pushed by kvijayan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f5c54b02982
Fix usage of nsIDocShellTreeItem in DocAccessibleWrap::DocAccessibleWrap. r=kmag
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.