1572831 - Fix usage of nsIDocShellTreeItem in DocAccessibleWrap::DocAccessibleWrap

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P2)

Description

[Kannan Vijayan [:djvj]]

In accessible/android/DocAccessible.cpp, in the constructor for DocAccessible (https://searchfox.org/mozilla-central/source/accessible/android/DocAccessibleWrap.cpp#27):

nsIDocShellTreeItem is queried for it's parent. The logic then checks to see if the parent is null, or if the parent's ItemType is chrome when the current treenode is content. In this case, it assigns 'kNoId' to the mId field.

It's possible under post-fission behaviour that GetInProcessParent() returns null when the parent is out-of-process. This might lead to erroneously assining kNoId for a tree-item that has a valid out-of-process content parent.

The logic in the conditional should be adjusted to use BrowsingContext to check if an OOP parent exists, and if so query its ItemType.

Comment 1

[Chris Peterson [:cpeterson]]

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Comment 2

[Kannan Vijayan [:djvj]]

Attachment: Bug 1572831 - Fix usage of nsIDocShellTreeItem in DocAccessibleWrap::DocAccessibleWrap. r?kmag

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f5c54b02982
Fix usage of nsIDocShellTreeItem in DocAccessibleWrap::DocAccessibleWrap. r=kmag

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3f5c54b02982