Closed Bug 1572841 Opened 3 months ago Closed 3 months ago

Avoid loading JSMs eagerly in Discovery Stream

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 70
Iteration:
70.3 - Aug 5 - 18
Tracking Status
firefox69 - verified
firefox70 --- verified

People

(Reporter: thecount, Assigned: thecount)

References

(Blocks 2 open bugs)

Details

(Keywords: github-merged)

Attachments

(2 files)

Similar to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1568197

I think we have a few places in Discovery Stream Feed where we might be able to get a boost in load time.

I'll do some more perf tests on that.

Assignee: nobody → sdowne
Iteration: --- → 70.3 - Aug 5 - 18
Priority: -- → P1

[Tracking Requested - why for this release]: The code is really small and it has some performance wins, I think it's worth uplifting.

Doesn't sound like this is significant enough to warrant tracking for 69, but I'm still happy to consider an uplift request when the time comes if the patch isn't risky.

Comment on attachment 9084912 [details]
uplift 1572841 - Avoid loading JSMs eagerly in Discovery Stream

Beta/Release Uplift Approval Request

  • User impact if declined: Performance on newtab first run
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Just regression checking, this should end up doing the same thing as before.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changing how we import a few jsms so they don't load until we need them.
  • String changes made/needed: none
Attachment #9084912 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Blocks: 1573174
Status: NEW → RESOLVED
Closed: 3 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Comment on attachment 9084912 [details]
uplift 1572841 - Avoid loading JSMs eagerly in Discovery Stream

New Tab Page perf improvement. Approved for 69.0b14.

Attachment #9084912 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

No regressions have been found on about:newpage on Nightly v70.0a1 build ID: 20190813215212 on Windows 10 and Ubuntu 18.04.
Waiting for Beta 14 to verify.

Also verified in Beta14 v69.0b14 build ID 20190814030729 on Windows 10. No regression of any kind have been observed on the about:newpage page.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.