1572841 - Avoid loading JSMs eagerly in Discovery Stream

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Scott [:thecount] Downe]

Similar to this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1568197

I think we have a few places in Discovery Stream Feed where we might be able to get a boost in load time.

I'll do some more perf tests on that.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5242

Comment 2

[Scott [:thecount] Downe]

Testing the above patch, I got https://docs.google.com/document/d/1Zg0c6eln0r7MIzVdVf293-3onhhlUFhRJ0UMp7Erc4E/edit

Comment 3

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: The code is really small and it has some performance wins, I think it's worth uplifting.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Doesn't sound like this is significant enough to warrant tracking for 69, but I'm still happy to consider an uplift request when the time comes if the patch isn't risky.

Comment 5

[Scott [:thecount] Downe]

Attachment: uplift 1572841 - Avoid loading JSMs eagerly in Discovery Stream

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 9084912 [details]
uplift 1572841 - Avoid loading JSMs eagerly in Discovery Stream

Beta/Release Uplift Approval Request

• User impact if declined: Performance on newtab first run
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Just regression checking, this should end up doing the same thing as before.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Changing how we import a few jsms so they don't load until we need them.
• String changes made/needed: none

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/7d5723904550

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9084912 [details]
uplift 1572841 - Avoid loading JSMs eagerly in Discovery Stream

New Tab Page perf improvement. Approved for 69.0b14.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/614c32bb2bb4

Comment 10

[Daniel Bodea [:danibodea]]

No regressions have been found on about:newpage on Nightly v70.0a1 build ID: 20190813215212 on Windows 10 and Ubuntu 18.04.
Waiting for Beta 14 to verify.

Comment 11

[Daniel Bodea [:danibodea]]

Also verified in Beta14 v69.0b14 build ID 20190814030729 on Windows 10. No regression of any kind have been observed on the about:newpage page.