1572890 - toolbar_field_highlight does not apply to selection of text in the search bar (theme api compat)

Status: RESOLVED FIXED

(WebExtensions :: Themes, defect, P5)

Description

[Asif Youssuff]

Attachment: manifest.json

Noticed that the toolbar_field_highlight does not apply to selection of text in the search bar (unlike what it says in https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme )

Steps to reproduce:

1. Load theme via about:debugging (attached)
2. Ensure that a separate search box is enabled.
3. type text into search box
4. select text in search box

What happens:

The custom (light purple) highlight color is not used.

Expected result:

The custom highlight color is used like it is in the address bar.

This has been an issue since 67.

Comment 1

[Asif Youssuff]

Attachment: Screenshot from 2019-08-09 20-25-48.png

Comment 2

[Asif Youssuff]

As far as I can tell, this may not be a regression, since toolbar_field_highlight may not have existed prior. I could be wrong though.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Miruna Curtean]

The extension could not be used to test successfully on macOS High Sierra 10.13.6 so the focus rested on Windows 10 Pro with 64-bit.
Because there was no known good version it was rather random and difficult to search for a regression window so I went as far as 08 May 2018 on build 60.0 where the extension did not even work. Starting with release build 62 the extension works and the address bar text is highlighted but not the search bar. That is available for all release versions up to 67 and in the latest latest Nightly 71.0a1 (20190930095343), Beta 70.0b10 (20190926005616) and Release 69.0.1 (20190917135527) builds as well.
I don't think this can be considered a regression, so could the specific keywords be removed?

Comment 6

[Harry Twyford]

Fixed in bug 1720784.