1720784 - Hard-to-read Find bar text when using a theme with brighttext toolbar and darktext URL bar

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

Attachment: image.png

+++ This bug was initially created as a clone of Bug #1710934 +++

STR:

1. On macOS, be running Nightly and ensure widget.macos.respect-system-appearance is set to true
2. Install this theme: https://addons.mozilla.org/en-US/firefox/addon/blueshift/
3. On any tab where there's pre-existing text in the URL bar, open the findbar with Cmd-F

ER:

The text should be readable - ideally dark text on a light background.

AR:

The text is dark on a dark background. See screenshot.

Comment 1

[Harry Twyford]

Attachment: Bug 1720784 - Support toolbar-field-highlight in searchbar and fix theme mismatch issue. r?#desktop-theme-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03883718a7d7
Support toolbar-field-highlight in searchbar and fix theme mismatch issue. r=desktop-theme-reviewers,dao

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/03883718a7d7

Comment 4

[Oana Botisan, Desktop QA]

Managed to reproduce the issue on Nightly 2021-07-15 using macOS 10.15.
Retested everything using Firefox 92.0b2 and Nightly 93.0a1 on the same os. The issue is not reproducing anymore.