1572925 - "privacy.restrict3rdpartystorage.url_decorations" preference appeared/showed itself in "Important Locked Preferences" section in about:support/Troubleshooting Information after landing patches from bug #1571770

Status: VERIFIED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR1:

1. Open about:support/Troubleshooting Information
2. Go to "Important Locked Preferences" section

and see that "privacy.restrict3rdpartystorage.url_decorations" preference is listed as locked

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:Virtual, could you try to find a regression range in using for example mozregression?

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Found commit message:
Bug 1571770 - Part 2: Package antitracking.manifest in packaged builds; r=baku

Differential Revision:
https://phabricator.services.mozilla.com/D40844

Comment 3

[Marcia Knous [:marcia]]

Hello Ehsan - Comment 2 shows Bug 1571770 might be the regressing bug. Can you take a look? thanks.

Comment 4

[(no longer active)]

This is working as expected. This isn't meant to be a preference for users to change. It is locked to avoid users accidentally modifying it.

Comment 5

[(no longer active)]

Actually, we should probably not show this pref in about:support to avoid misleading people (since this isn't really an "important locked preference"). :-) The only reason this is a preference in the first place is that preferences give us a quick and dirty mechanism to share a small string from the parent process to content processes.

Let me write a quick fix for that.

Comment 6

[(no longer active)]

Attachment: Bug 1572925 - Make sure that about:support doesn't list the URL decorations pref as an important locked preference;

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d13f6714fc13
Make sure that about:support doesn't list the URL decorations pref as an important locked preference; r=baku

Comment 8

[(no longer active)]

Comment on attachment 9085555 [details]
Bug 1572925 - Make sure that about:support doesn't list the URL decorations pref as an important locked preference;

Beta/Release Uplift Approval Request

• User impact if declined: Users who look at the Locked Preferences section of about:support may get confused.

(This is a low risk, nice-to-have patch, but really if we don't take it nothing super bad would happen.)

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It only affects the data that we show inside the Locked Preferences table in about:support, and has an automated test.
• String changes made/needed: None

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d13f6714fc13

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9085555 [details]
Bug 1572925 - Make sure that about:support doesn't list the URL decorations pref as an important locked preference;

Avoids showing a locked pref in about:support that we don't want visible there. Approved for 69.0b15.

Comment 11

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/43cb3f862bc3

Comment 12

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 70.0a1 (2019-08-16) and in latest Mozilla Firefox Beta 69, so I'm marking this bug as VERIFIED.
Thank you very much! \o/