1590364 - Permafailing toolkit/modules/tests/browser/browser_Troubleshoot.js | Schema mismatch, Error: Validation error: Object has property dom.postMessage.sharedArrayBuffer when Gecko 72 merges to Beta on 2019-12-02

Status: VERIFIED FIXED

(Toolkit :: General, defect)

Description

[Natalia Csoregi [:nataliaCs]]

[Tracking Requested - why for this release]:
Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=bc0623098f500c5329979c003c2386be2b51fa2f&searchStr=browser-chrome&selectedJob=272367616

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=272367616&repo=try&lineNumber=4759

[task 2019-10-22T12:04:17.900Z] 12:04:17 INFO - TEST-START | toolkit/modules/tests/browser/browser_Troubleshoot.js
[task 2019-10-22T12:04:18.162Z] 12:04:18 INFO - GECKO(4953) | WebGL(0x61b0002bea80)::ForceLoseContext
[task 2019-10-22T12:04:18.197Z] 12:04:18 INFO - GECKO(4953) | WebGL(0x61b000224380)::ForceLoseContext
[task 2019-10-22T12:04:18.228Z] 12:04:18 INFO - TEST-INFO | started process screentopng
[task 2019-10-22T12:04:18.655Z] 12:04:18 INFO - TEST-INFO | screentopng: exit 0
[task 2019-10-22T12:04:18.659Z] 12:04:18 INFO - TEST-UNEXPECTED-FAIL | toolkit/modules/tests/browser/browser_Troubleshoot.js | Schema mismatch, Error: Validation error: Object has property dom.postMessage.sharedArrayBuffer.bypassCOOP_COEP.insecure.enabled not in schema: object={"dom.postMessage.sharedArrayBuffer.bypassCOOP_COEP.insecure.enabled":false}, schema={"required":true,"type":"object","properties":{}} -
[task 2019-10-22T12:04:18.659Z] 12:04:18 INFO - Stack trace:
[task 2019-10-22T12:04:18.660Z] 12:04:18 INFO - chrome://mochikit/content/browser-test.js:test_ok:1297
[task 2019-10-22T12:04:18.661Z] 12:04:18 INFO - chrome://mochitests/content/browser/toolkit/modules/tests/browser/browser_Troubleshoot.js:snapshotSchema/<:41
[task 2019-10-22T12:04:18.662Z] 12:04:18 INFO - TEST-PASS | toolkit/modules/tests/browser/browser_Troubleshoot.js | The pref should be set: javascript.troubleshoot -
[task 2019-10-22T12:04:18.664Z] 12:04:18 INFO - TEST-PASS | toolkit/modules/tests/browser/browser_Troubleshoot.js | The pref should be set: troubleshoot.foo -

Comment 1

[Tom Tung [:tt, :ttung]]

Remove this line fix the issue on my Mac https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/toolkit/modules/tests/browser/browser_Troubleshoot.js#288

Comment 2

[Tom Tung [:tt, :ttung]]

(In reply to Tom Tung [:tt, :ttung] from comment #1)

Remove this line fix the issue on my Mac https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/toolkit/modules/tests/browser/browser_Troubleshoot.js#288

I guess that is ensuring locked pref should be invisible in about:support or something like that

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Screen Shot 2019-10-22 at 18.06.38.png

Comment 4

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1590364 - Not listing the bypass security check pref for postMessage in about:support;

Comment 5

[Tom Tung [:tt, :ttung]]

Mostly is to confirm (I lean to not show this to users here since it's mostly for developers and for testing; Also, I'm not sure if it's "important") : Anne, does it matter if we are not showing the pref on "about:support" like comment #3? If not, please feel free to let me know. And would be great if you could explain to me. Thanks!

Comment 6

[Anne (:annevk)]

If someone flips this preference for some reason and hits a problem because of it, I guess it would be good if it ends up in about:support even if it seems somewhat unlikely for normal users. Why are we hitting this error for this preference and not others? What's special about it?

Comment 7

[Tom Tung [:tt, :ttung]]

(In reply to Anne (:annevk) from comment #6)

If someone flips this preference for some reason and hits a problem because of it, I guess it would be good if it ends up in about:support even if it seems somewhat unlikely for normal users. Why are we hitting this error for this preference and not others? What's special about it?

It is a test failure and the test looks like to ensure there is no unexpected pref shown on the troubleshooting session in about:support page. If someone wants to add one, they need to change the test intentionally.

We decided to lock the pref on channels like Release and some of Beta to protect users. And that's why it led a test failure on Beta.

My point is that we could either add an exception (showing in the about:support page) in the test or not showing the pref on that. Since the title of that is "Important locked pref" and it's a page for troubleshooting, combined that with my understanding of the purpose of this pref, we probably don't want to show that on that page to increase confusion for users.

Note that we can still find out the pref(dom.postMessage.sharedArrayBuffer.bypassCOOP_COEP.insecure.enabled) is locked (cannot be changed) in about:config page in the non-Nightly and non-Dev channels.

Comment 8

[Andreea Pavel [:apavel]]

Importing the patch makes the failures go away: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa4b1c78a05778a89525fc26e90a519c52b6e40f&searchStr=browser%2Cchrome&group_state=expanded&selectedJob=272550012

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b22b34f260b4
Not listing the bypass security check pref for postMessage in about:support; r=nika

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b22b34f260b4

Comment 11

[Cosmin Sabou [:CosminS]]

Fix verified in beta-sims: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&author=rgurzau%40mozilla.com&fromchange=ad4e908d3dac91b25d45830c7e382155e9bd8a14&searchStr=browser%2Cchrome&selectedJob=273150469

Comment 12

[Intermittent Failures Robot]

8 failures in 4182 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 8

Platform breakdown:

• windows10-64-qr: 1
• windows10-64: 1
• linux64-shippable: 1
• windows10-64-shippable-qr: 1
• windows10-64-shippable: 2
• windows7-32-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1590364&startday=2019-10-21&endday=2019-10-27&tree=all