Closed Bug 1573208 Opened 5 years ago Closed 5 years ago

Add --browsertime flag to Raptor test harness

Categories

(Testing :: Raptor, enhancement, P1)

Version 3
enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: nalexander, Assigned: nalexander)

References

Details

Attachments

(3 files, 1 obsolete file)

The WIP I built in Bug 1566171 used --browsertime-* flag values and explicit browsertime test configurations to opt-in to browsertime. We've decided to add a --browsertime flag, similar to the existing --gecko-profile flag, to opt-in to using browsertime.

This is follow-up to Bug 1566171 and required for Bug 1572804.

An error crept in, resulting in:

[task ...] InterpreterError: InterpreterError: infix: [..] expects integer [..] integer

At some point, suite became a string name and not an object with a
string name member.

Depends on D41602

This requires generalizing the existing flags from paths to possibly
being paths. The os.path.expandvars allows to refer to
MOZ_FETCHES_DIR symbolically in the build scripts (which aren't
invoked by the shell before execution, leaving us to expand shell
variables).

Depends on D41603

For now, this just:

  • updates the TreeHerder symbol
  • includes the --browsertime flag
  • adds the browsertime toolchain dependency.

Depends on D41604

Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Priority: -- → P1

Comment on attachment 9084792 [details]
Bug 1573208 - Pre: Fix ./mach try --gecko-profile .... r?tomprince

Revision D41603 was moved to bug 1575014. Setting attachment 9084792 [details] to obsolete.

Attachment #9084792 - Attachment is obsolete: true
Attachment #9084794 - Attachment description: Bug 1573208 - Part 2: Add `--browsertime` flag to Raptor test jobs. r?tomprince f?rwood → Bug 1573208 - Part 2: Add `--browsertime` flag to Raptor test jobs. r?glandium
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b26ecd009318
Pre: Avoid duplicated `extra-options`. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/fb3299d99156
Part 1: Add `--browsertime` flag to Raptor harness. r=rwood
https://hg.mozilla.org/integration/autoland/rev/cc887ca2e5a1
Part 2: Add `--browsertime` flag to Raptor test jobs. r=glandium
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Blocks: 1581580
Blocks: 1587154
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: