Open Bug 1573630 Opened 1 year ago Updated 2 months ago

Fix usage of nsIDocShellTreeItem in nsCoreUtils::IsTabDocument

Categories

(Core :: Disability Access APIs, enhancement, P2)

enhancement

Tracking

()

Fission Milestone M6

People

(Reporter: djvj, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

https://searchfox.org/mozilla-central/source/accessible/base/nsCoreUtils.cpp#357

This function determines whether a document is a tab document or not. For content documents, it checks for a null parent. For chrome documents, it checks whether the parent of the document is equal to the root of the document.

Only the first case should need fixing. Explained below.

In the former case (content-process), the logic should do the following.

  1. Check if parent is null, if non-null, then this is not a tab document.
  2. If the parent is null, then check for an out-of-process parent, and return false if it exists, otherwise true.

In the latter case (chrome process), the logic should work as is, since chrome process contains everything in-process, and should not have any notion of "out of process" parents for the current doc. If this assumption is false, then an appropriate fix is needed for the chrome-process case as well.

Component: DOM: Core & HTML → Disability Access APIs
Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:simple]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
You need to log in before you can comment on or make changes to this bug.