Closed Bug 1573639 Opened 6 years ago Closed 6 years ago

Almost total MozMill failure in debug builds on 2019-08-13: Assertion failure: sheet->ParsingMode() == aParsingMode

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: jorgk-bmo, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Most tests fail with:
Assertion failure: sheet->ParsingMode() == aParsingMode, at /builds/worker/workspace/build/src/layout/style/Loader.cpp:989
TEST-UNEXPECTED-FAIL | Disconnect Error: Application unexpectedly closed
PROCESS-CRASH | content-policy | application crashed [@ mozilla::css::Loader::CreateSheet(nsIURI*, nsIContent*, nsIPrincipal*, mozilla::css::SheetParsingMode, mozilla::CORSMode, nsIReferrerInfo*, nsTSubstring<char16_t> const&, bool, mozilla::css::StyleSheetState&, RefPtr<mozilla::StyleSheet>*)]

Looks like it comes from here:
https://hg.mozilla.org/mozilla-central/rev/bec4c05b5a70d74b1b4fe7fff264b1428d06b68e#l1.129

+      MOZ_ASSERT(sheet->ParsingMode() == aParsingMode);
Flags: needinfo?(emilio)

Will be fixed by one of the patches in bug 1571530 that haven't landed yet (https://phabricator.services.mozilla.com/D40692 in particular).

Flags: needinfo?(emilio)
Summary: Almost total MozMill failure in debug builds on 2019-08-13 → Almost total MozMill failure in debug builds on 2019-08-13: Assertion failure: sheet->ParsingMode() == aParsingMode

Emilio, any news here? This has taken down our test suite in debug builds and local debug builds are also crashing unless we take out that assert.

Flags: needinfo?(emilio)

The patches landed this morning.

Flags: needinfo?(emilio)

Fixed by landings in bug 1571530. However, not quite, there's a new crash now. I'll file another bug.
EDIT: Follow-up in bug 1574596.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
You need to log in before you can comment on or make changes to this bug.