1573829 - Port | Bug 524092 "View Image Info" command is not carried out if "Page Info" window is already opened| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Ian Neal]

Port:

• Bug 524092 - "View Image Info" command is not carried out if "Page Info" window is already opened
• Bug 524092 - fix for compatibility with "View Frames" add-on
• Bug 1058543 - Make page info work again in e10s

Comment 1

[Ian Neal]

Attachment: add loadTab function

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Page Info might not always work
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9085436 [details] [diff] [review]
add loadTab function

loadTab function:

> +  // set gImageElement if present
> +  if ("arguments" in window && window.arguments.length >= 1 &&
> +      window.arguments[0].imageElement)
> +    gImageElement = window.arguments[0].imageElement;

This doesn't seem to work when called from  win.resetPageInfo(args) in navigator.js.
The page info is reloaded but the image is not selected. 

Removing the if and using the same assignment as the Fx patch fixes it for me.
> // set gImageElement if present
> gImageElement = args && args.imageElement;

Makes also more sense because args is the actual argument here already.

See:
https://hg.mozilla.org/mozilla-central/rev/44ff9f905317
https://hg.mozilla.org/mozilla-central/rev/0d83b7b45431

r/a+ with that fixed.

Comment 3

[Ian Neal]

Attachment: add loadTab function v1.1

Fix missing change, carrying forward r/a+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/93c1fb77105c
Port |Bug 524092 - "View Image Info" command is not carried out if "Page Info" window is already opened| to SeaMonkey. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/4c7254e896da4a576e86382325eb5e58f897ce00