1573953 - Do not add impressions for moments page pref check

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Kate Hudson :k88hudson]

We should not be adding impressions at the point we add a moments URL to the pref; in the future, we can add impressions to the point we show the moments page if necessary

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5256

Comment 2

[Ed Lee :Mardak]

Just documenting that the failure is that every 5 minutes, the once pref is cleared then rechecked if a message should be shown, but every time the once pref is set, an impression is associated to the message thus possibly hitting the daily frequency cap for the provider.

With this pref:

browser.newtabpage.activity-stream.asrouter.providers.cfr;{"id":"cfr-remote","enabled":true,"type":"remote-settings","bucket":"messaging-system","frequency":{"custom":[{"period":"daily","cap":1}]},"categories":["cfrAddons","cfrFeatures"]}

Assuming the staged message targeting matches (profile age "created" 365 days ago), after 5 minutes, the "once" pref would be set.
After another 5 minutes, the bug appears clearing the "once" pref. Instead, the "once" pref should still have the url (and an updated "expire" time).

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/feeaf170fca669a675eff2cb16bd56b0a329b508

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/cf52300e04c9

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

How can this be verified by QA? Could you please provide us with some steps?

Comment 6

[Andrei Oprea [:andreio]]

On a fresh profile:

1. Set browser.newtabpage.activity-stream.asrouter.providers.panel_local_testing to {"id":"panel_local_testing", "cohort": "SHOW_TEST"}
2. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true
3. Wait for WNP_THANK_YOU to trigger (browser.startup.homepage_override.once is set after 5 minutes)

Expected:

1. In the admin page the message is show to have (0 impressions) next to the name/buttons
2. No IMPRESSION telemetry ping is sent for WNP_THANK_YOU

Comment 7

[Cristian Baica [:cbaica], Release Desktop QA]

Tested using the steps provided by Andrei.
The issue is verified fixed using Fx70.0a1 and Fx69.0b15 on ubuntu 18.04, windows 10 x64 and macOS 10.13. The 'browser.startup.homepage_override.once' is correctly set after 5 minutes. No impressions are displayed on the message, inside the admin page.