Closed Bug 1574087 Opened 3 years ago Closed 3 years ago

Make MathML length, dir, display, displaystyle and mathvariant case insensitive

Categories

(Core :: MathML, enhancement)

Product:
Core
Component:
MathML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: fredw, Assigned: fredw)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1574087. Make MathML length, dir, display, displaystyle and mathvariant case insensitive. r=emilio
47 bytes, text/x-phabricator-request
Details | Review

See https://github.com/mathml-refresh/mathml/issues/22

We already do that for color.

This is easy to do and will increase our pass rate for MathML WPT tests.

Blocks: mathml-core
Summary: Make MathML length, dir, displaystyle and mathvariant case insensitive → Make MathML length, dir, display, displaystyle and mathvariant case insensitive

See https://github.com/mathml-refresh/mathml/issues/22

  • mathml/relations/css-styling/attribute-mapping-001.html (length, dir)
  • mathml/relations/html5-tree/display-1.html (display)
  • mathml/relations/css-styling/displaystyle-1.html (displaystyle)
  • mathml/relations/css-styling/displaystyle-2.html (displaystyle)
  • mathml/relations/css-styling/mathvariant-case-sensitivity.html (mathvariant)

Note:

  • mathml/relations/css-styling/attribute-mapping-002.html also checks
    case insensitiveness of mathvariant and displaystyle but for now we map
    these attributes to internal -moz-* CSS properties.
  • mathcolor and mathbackground values are already case insensitive, this
    is verified by mathml/relations/css-styling/attribute-mapping-001.html
Keywords: checkin-needed

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dccb45167d3
Make MathML length, dir, display, displaystyle and mathvariant case insensitive. r=emilio

Keywords: checkin-needed
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18450 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging
Backout by malexandru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c290f5eed098
Backed out changeset 1dccb45167d3 for causing reftest failures in 355548-3.xml

Backed out changeset 1dccb45167d3 for causing reftest failures in 355548-3.xml

Backout link: https://hg.mozilla.org/integration/autoland/rev/c290f5eed098cde975a779d88e43b260f2d4c222

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunning%2Cpending%2Crunnable&searchStr=reftest-e10s%2C%28r&fromchange=1dccb45167d39cb443d42afc46fab8ad55426af5&tochange=c290f5eed098cde975a779d88e43b260f2d4c222&selectedJob=261775124

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261775124&repo=autoland&lineNumber=34759

[task 2019-08-15T12:18:17.809Z] 12:18:17 INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3.xml == file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3-ref.xml
[task 2019-08-15T12:18:17.809Z] 12:18:17 INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3.xml | 524 / 2071 (25%)
[task 2019-08-15T12:18:17.856Z] 12:18:17 INFO - ++DOMWINDOW == 119 (0x1504d0400) [pid = 1905] [serial = 1411] [outer = 0x128035020]
[task 2019-08-15T12:18:17.906Z] 12:18:17 INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3-ref.xml | 524 / 2071 (25%)
[task 2019-08-15T12:18:17.907Z] 12:18:17 INFO - ++DOMWINDOW == 120 (0x128ebd400) [pid = 1905] [serial = 1412] [outer = 0x128035020]
[task 2019-08-15T12:18:17.957Z] 12:18:17 INFO - --DOMWINDOW == 119 (0x11eede400) [pid = 1905] [serial = 1385] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.958Z] 12:18:17 INFO - --DOMWINDOW == 118 (0x150e86400) [pid = 1905] [serial = 1389] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.965Z] 12:18:17 INFO - --DOMWINDOW == 117 (0x151b78800) [pid = 1905] [serial = 1381] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.965Z] 12:18:17 INFO - --DOMWINDOW == 116 (0x151b7c800) [pid = 1905] [serial = 1382] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2b.html]
[task 2019-08-15T12:18:17.965Z] 12:18:17 INFO - --DOMWINDOW == 115 (0x150404c00) [pid = 1905] [serial = 1386] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2d.html]
[task 2019-08-15T12:18:17.965Z] 12:18:17 INFO - --DOMWINDOW == 114 (0x150fb9000) [pid = 1905] [serial = 1380] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2-ref.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 113 (0x150fadc00) [pid = 1905] [serial = 1379] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2a.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 112 (0x1505b8400) [pid = 1905] [serial = 1375] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-1k.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 111 (0x151c0b000) [pid = 1905] [serial = 1384] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2c.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 110 (0x150e38400) [pid = 1905] [serial = 1388] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-2e.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 109 (0x151b81000) [pid = 1905] [serial = 1383] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 108 (0x15040bc00) [pid = 1905] [serial = 1387] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 107 (0x150e88000) [pid = 1905] [serial = 1378] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 106 (0x150e8c400) [pid = 1905] [serial = 1377] [outer = 0x0] [url = file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/352980-1l.html]
[task 2019-08-15T12:18:17.966Z] 12:18:17 INFO - --DOMWINDOW == 105 (0x150e37800) [pid = 1905] [serial = 1376] [outer = 0x0] [url = data:text/html;charset=UTF-8,%3C%21%2D%2DCLEAR%2D%2D%3E]
[task 2019-08-15T12:18:18.157Z] 12:18:18 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3.xml == file:///Users/cltbld/tasks/task_1565870716/build/tests/reftest/tests/layout/reftests/bugs/355548-3-ref.xml | image comparison, max difference: 255, number of differing pixels: 3305
[task 2019-08-15T12:18:18.157Z] 12:18:18 INFO - REFTEST IMAGE 1 (TEST):

Flags: needinfo?(fred.wang)

I updated 355548-3.xml to reflect that length units are now case insensitive (like for CSS lengths). I think we should consider moving all these old MathML tests into layout/reftests/mathml (or even export them to testing/web_platform/tests/mathml).

Flags: needinfo?(fred.wang)
Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2213833fcec3
Make MathML length, dir, display, displaystyle and mathvariant case insensitive. r=emilio

Keywords: checkin-needed
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/2213833fcec3

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → fred.wang
You need to log in before you can comment on or make changes to this bug.