1574115 - Port bug 1573435 - Use toolchain fetches for more task kinds

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Decision task broken.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ecccd8455117
Port bug 1573435 - Use toolchain fetches for more task kinds; rs=bustage-fix DONTBUILD

Comment 2

[Geoff Lankow (:darktrojan) [OOO, back 5 Jan]]

Attachment: 1574115-toolchains.diff

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9085709 [details] [diff] [review]
1574115-toolchains.diff

Review of attachment 9085709 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2f2113a4e5e4
Follow up: Fix path to sccache executable. rs=bustage-fix

Comment 6

[Rob Lemley [:rjl]]

Attachment: Follow-up: Fix paths to macOS filesystem tools

For failing macOS L10n repacks.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9086132 [details] [diff] [review]
Follow-up: Fix paths to macOS filesystem tools

OK. I saw a whole lot more $MOZ_FETCHES_DIR in the bug we're porting.

Comment 8

[Rob Lemley [:rjl]]

Fortunately most of mozconfig comes from including Firefox's mozconfig files. The sccache file is one notable exception, and apparently so is the macOS l10n repack config.
Based on the changes in that bug, it looks like the two strings to replace are $topsrcdir and $TOOLTOOL_DIR.
I searched mail/config/mozconfigs for both. The remaining $topsrcdir references all point to other mozconfig files to include, so those are okay.
The $TOOLTOOL_DIR references point to the MAPI headers path, and since Windows builds seem to be working, I'm not inclined to change those.
I'm fairly certain this covers all of them.

Comment 9

[Jorg K (CEST = GMT+2)]

Good. Thanks for the research :-)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5db14b616149
Follow-up: Fix paths to macOS filesystem tools. r=jorgk