1574291 - Maximize window icon instead of restore window icon (Kubuntu 18.04.3, KDE Plasma 5.12.8, GTK 3)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement, P3)

Description

[u628052]

Attachment: Screenshot_20190815_230647.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Disable title bar on customization settings

Actual results:

When window is maximized, the "Maximize" icon is shown.

Expected results:

When window is maximized, the "Restore" icon should be shown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[mi2rivtj]

Still happening in FF 88.0.1 (KDE with Breeze-GTK).

Operating System: KDE neon 5.21
KDE Plasma Version: 5.21.5
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Kernel Version: 5.4.0-73-generic
OS Type: 64-bit
Graphics Platform: X11
Processors: 8 × Intel® Core™ i5-8265U CPU @ 1.60GHz
Memory: 15,5 GiB of RAM
Graphics Processor: Mesa Intel® UHD Graphics 620

Comment 4

[mi2rivtj]

Attachment: adwaita and breeze-qt .png

The weird thing is that this doesn't happen in Adwaita-GTK. If you look closely at the middle of the screenshot, the restore and maximize buttons are different.

Comment 6

[Leo_sk]

The irritating thing is that trying to override it with css doesn't hide the wrong icon, so I get stacked icons

Comment 7

[med medin]

This problem is still present with :

Firefox: 113.0.2
Operating System: Manjaro Linux
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.106.0
Qt Version: 5.15.9
Kernel Version: 6.3.4-1-MANJARO (64-bit)
Graphics Platform: Wayland

Comment 8

[med medin]

Attachment: Maximize button appears when Firefox is maximized

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1574291 - Render restore button, not just icon, when drawing titlebar. r=stransky

And attach it to the maximized headerbar, not to the regular one. Breeze
styles the button with background-image rather than icon-source.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c2b9be4b0db
Render restore button, not just icon, when drawing titlebar. r=stransky

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/0c2b9be4b0db