Support assertions in nested SpecialPowers.spawn calls
Categories
(Testing :: Mochitest, task)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
SpecialPowers.spawn callbacks have helpers which automatically proxy calls of Assert methods back to the scope which called spawn. Unfortunately, this only works when the caller scope has a working SimpleTest harness. In particular, this means that it does not work for nested SpecialPowers.spawn calls, where it would be particularly useful.
|
Assignee | |
Comment 1•5 years ago
|
||
Prior to this patch, assertions in SpecialPowers.spawn callbacks only work
when the caller was in a window with a SimpleTest harness.
This patch fixes that by registering a default assertion handler at the start
of a test, and sending assertions from any task without its own harness to
said default handler.
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/41b6d03a870caa7c4be2146ce8c8d84efdb20e79 Bug 1574296: Support assertions in nested SpecialPowers.span calls. r=mccr8
|
||
Comment 3•5 years ago
•
|
||
Backed out 9 changesets (bug 1574296, bug 1561705) for devtools failures in browser_dbg-breaking-from-console.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262406417&repo=mozilla-inbound&lineNumber=6053
Also: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262408611&repo=mozilla-inbound&lineNumber=31681
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d17f6700544d2ffbb52f5482e59e26805121f33d
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f836a6215abeb7a22c4225b4967bc8326cf6bb9 Bug 1574296: Support assertions in nested SpecialPowers.span calls. r=mccr8
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Description
•