1574296 - Support assertions in nested SpecialPowers.spawn calls

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Kris Maglione [:kmag]]

SpecialPowers.spawn callbacks have helpers which automatically proxy calls of Assert methods back to the scope which called spawn. Unfortunately, this only works when the caller scope has a working SimpleTest harness. In particular, this means that it does not work for nested SpecialPowers.spawn calls, where it would be particularly useful.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1574296: Support assertions in nested SpecialPowers.span calls. r=mccr8

Prior to this patch, assertions in SpecialPowers.spawn callbacks only work
when the caller was in a window with a SimpleTest harness.

This patch fixes that by registering a default assertion handler at the start
of a test, and sending assertions from any task without its own harness to
said default handler.

Comment 2

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/41b6d03a870caa7c4be2146ce8c8d84efdb20e79
Bug 1574296: Support assertions in nested SpecialPowers.span calls. r=mccr8

Comment 3

[Oana Pop-Rus]

Backed out 9 changesets (bug 1574296, bug 1561705) for devtools failures in browser_dbg-breaking-from-console.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=262406417&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=41b6d03a870caa7c4be2146ce8c8d84efdb20e79&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-devtools-chrome-e10s-2%2Cm%28dt2%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262406417&repo=mozilla-inbound&lineNumber=6053
Also: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262408611&repo=mozilla-inbound&lineNumber=31681

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d17f6700544d2ffbb52f5482e59e26805121f33d

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f836a6215abeb7a22c4225b4967bc8326cf6bb9
Bug 1574296: Support assertions in nested SpecialPowers.span calls. r=mccr8

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1f836a6215ab