Closed Bug 1574409 Opened 3 years ago Closed 3 years ago

Reduce code duplication in sccache configuration between Firefox and Thunderbird

Categories

(Thunderbird :: Build Config, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 74.0

People

(Reporter: rjl, Assigned: rjl)

Details

Attachments

(4 files)

There's a lot of effort duplicated between M-C:build/mozconfig.cache and C-C:build/mozconfig.sccache. Specifically the location of the sccache binary has changed twice in the past year (bug 1553339 and bug 1573435) leading to build bustage on C-C.

The Taskcluster migration to GCS may also soon come into play as sccache will migrate with it if I understand correctly.

Been looking at this. Our current sccache configuration is pretty broken.

For the above, sccache works within a single build, so some of the test programs that moz.configure compiles get cached, but it's useless between builds without access to the S3 storage.

Much of Firefox's mozocnfig.cache file is duplicated in Thunderbird's tree
in order to set a slightly different bucket name. This has led to broken buids
in the past.
The only difference is the first part of the name. With this change, a Thunderbird
mozconfig file can set $aws_prefix to "comm-central" before mozconfig.cache
gets included and be correctly configured.
GCP support is not required at this time.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pending approval of the M-C change.
Attachment #9123249 - Flags: review?(geoff)
Comment on attachment 9123249 [details] [diff] [review]
sccache_fix_C-C.patch

Nice work.
Attachment #9123249 - Flags: review?(geoff) → review+
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/integration/autoland/rev/8438b87f78ff
Make mozconfig.cache useable for Thunderbird builds. r=firefox-build-system-reviewers,mshal

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/16c59c865c45
Use Firefox's mozconfig.cache for Thunderbird. r=darktrojan

I think we're done here.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 74.0
You need to log in before you can comment on or make changes to this bug.