1574409 - Reduce code duplication in sccache configuration between Firefox and Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: Build Config, enhancement, P3)

Description

[Rob Lemley [:rjl]]

There's a lot of effort duplicated between M-C:build/mozconfig.cache and C-C:build/mozconfig.sccache. Specifically the location of the sccache binary has changed twice in the past year (bug 1553339 and bug 1573435) leading to build bustage on C-C.

The Taskcluster migration to GCS may also soon come into play as sccache will migrate with it if I understand correctly.

Comment 1

[Rob Lemley [:rjl]]

Attachment: sccache_errors_windows.png

Comment 2

[Rob Lemley [:rjl]]

Attachment: sccache_errors_c-beta.png

Comment 3

[Rob Lemley [:rjl]]

Been looking at this. Our current sccache configuration is pretty broken.

• It does not work for any of our Windows builds. attachment 9122442 [details]. The problem is this code: https://searchfox.org/comm-central/rev/2a51fd37d5525a70f1acf3610dc99f9473f3738e/build/mozconfig.sccache#28-35
  • When the build platform is Windows, the platform variable gets set, but the AWS_IAM_CREDENTIALS line is skipped. The result is sccache can't write to the S3 bucket, rendering it useless.
• Debug builds on c-beta and c-esr68 are not able to use sccache attachment 9122449 [details]. https://searchfox.org/comm-central/rev/2a51fd37d5525a70f1acf3610dc99f9473f3738e/build/mozconfig.sccache#12-23
  • The bucket does not get set for c-beta or c-esr. The existing value for bucket is pointing to a Firefox bucket which cannot be accessed.

For the above, sccache works within a single build, so some of the test programs that moz.configure compiles get cached, but it's useless between builds without access to the S3 storage.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1574409 - Make mozconfig.cache useable for Thunderbird builds. r?#firefox-build-system-reviewers

Much of Firefox's mozocnfig.cache file is duplicated in Thunderbird's tree
in order to set a slightly different bucket name. This has led to broken buids
in the past.
The only difference is the first part of the name. With this change, a Thunderbird
mozconfig file can set $aws_prefix to "comm-central" before mozconfig.cache
gets included and be correctly configured.
GCP support is not required at this time.

Comment 5

[Rob Lemley [:rjl]]

Attachment: sccache_fix_C-C.patch

Pending approval of the M-C change.

Comment 6

[Geoff Lankow (:darktrojan)]

Comment on attachment 9123249 [details] [diff] [review]
sccache_fix_C-C.patch

Nice work.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8438b87f78ff
Make mozconfig.cache useable for Thunderbird builds. r=firefox-build-system-reviewers,mshal

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8438b87f78ff

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/16c59c865c45
Use Firefox's mozconfig.cache for Thunderbird. r=darktrojan

Comment 10

[Geoff Lankow (:darktrojan)]

I think we're done here.