1574557 - error: use of undeclared identifier '__isinf'

Status: UNCONFIRMED

(Firefox Build System :: General: Unsupported Platforms, defect)

Description

[ng0]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

build www/firefox from pkgsrc, version 68.0.2 on a system with clang + llvm from NetBSD 9.99.4 base (clang version:
clang version 7.0.0 (trunk r337282)
Target: x86_64--netbsd
Thread model: posix
InstalledDir: /usr/bin
)

Actual results:

/usr/work/www/firefox/work/.cwrapper/bin/clang++ -o Decimal.o -c -I/usr/work/www/firefox/work/build/dist/system_wrappers -include /usr/work/www/firefox/work/firefox-68.0.2/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/usr/work/www/firefox/work/firefox-68.0.2/mfbt -I/usr/work/www/firefox/work/build/mfbt -I/usr/work/www/firefox/work/firefox-68.0.2/mfbt/double-conversion -I/usr/work/www/firefox/work/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/usr/work/www/firefox/work/build/dist/include/nss -I/usr/X11R7/include/pixman-1 -fPIC -DPIC -DMOZILLA_CLIENT -include /usr/work/www/firefox/work/build/mozilla-config.h -Qunused-arguments -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -O2 -I/usr/pkg/include/nspr -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -D__HAVE_INLINE___ISINF -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables -MD -MP -MF .deps/Decimal.o.pp -Wno-implicit-fallthrough /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp
In file included from /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp:32:
In file included from /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/moz-decimal-utils.h:16:
In file included from /usr/work/www/firefox/work/build/dist/include/mozilla/FloatingPoint.h:15:
In file included from /usr/work/www/firefox/work/build/dist/include/mozilla/MathAlgorithms.h:15:
In file included from /usr/work/www/firefox/work/build/dist/system_wrappers/cmath:3:
/usr/include/c++/cmath:393:12: error: use of undeclared identifier '__isinf'
return isinf(__lcpp_x);
^
/usr/include/math.h:484:20: note: expanded from macro 'isinf'
#define isinf(__x) __isinf(__x)
^
/usr/include/c++/cmath:403:12: note: in instantiation of function template specialization '__libcpp_isinf<double>' requested here
return __libcpp_isinf((typename std::__promote<_A1>::type)__lcpp_x);
^
/usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp:698:14: note: in instantiation of function template specialization 'isinf<double>' requested here
if (std::isinf(doubleValue))
^
1 error generated.
gmake[3]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/rules.mk:828: Decimal.o] Error 1
gmake[3]: Leaving directory '/usr/work/www/firefox/work/build/mfbt'
gmake[2]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/recurse.mk:74: mfbt/target] Error 2
gmake[2]: Leaving directory '/usr/work/www/firefox/work/build'
gmake[1]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/recurse.mk:34: compile] Error 2
gmake[1]: Leaving directory '/usr/work/www/firefox/work/build'
gmake: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/rules.mk:413: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/www/firefox
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/www/firefox

Expected results:

firefox builds successfully.

I am not 100% sure, but it might be that this patch in previous versions - never commited in pkgsrc - skipped past it:

--- config/make-system-wrappers.py.orig 2019-01-24 18:48:39.000000000 +0000
+++ config/make-system-wrappers.py
@@ -6,6 +6,7 @@ import os
from mozbuild.util import FileAvoidWrite

header_template = '''#pragma GCC system_header
+#define __isinf(x) __builtin_isinf(x)
#pragma GCC visibility push(default)
{includes}
#pragma GCC visibility pop

Comment 1

[ng0]

Since I did not expect markdown in bugzilla, here is the message again:

/usr/work/www/firefox/work/.cwrapper/bin/clang++ -o Decimal.o -c  -I/usr/work/www/firefox/work/build/dist/system_wrappers -include /usr/work/www/firefox/work/firefox-68.0.2/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/usr/work/www/firefox/work/firefox-68.0.2/mfbt -I/usr/work/www/firefox/work/build/mfbt -I/usr/work/www/firefox/work/firefox-68.0.2/mfbt/double-conversion -I/usr/work/www/firefox/work/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/usr/work/www/firefox/work/build/dist/include/nss -I/usr/X11R7/include/pixman-1 -fPIC -DPIC -DMOZILLA_CLIENT -include /usr/work/www/firefox/work/build/mozilla-config.h -Qunused-arguments -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -O2 -I/usr/pkg/include/nspr -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/X11R7/include/freetype2 -D__HAVE_INLINE___ISINF -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables  -MD -MP -MF .deps/Decimal.o.pp  -Wno-implicit-fallthrough /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp
In file included from /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp:32:
In file included from /usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/moz-decimal-utils.h:16:
In file included from /usr/work/www/firefox/work/build/dist/include/mozilla/FloatingPoint.h:15:
In file included from /usr/work/www/firefox/work/build/dist/include/mozilla/MathAlgorithms.h:15:
In file included from /usr/work/www/firefox/work/build/dist/system_wrappers/cmath:3:
/usr/include/c++/cmath:393:12: error: use of undeclared identifier '__isinf'
    return isinf(__lcpp_x);
           ^
/usr/include/math.h:484:20: note: expanded from macro 'isinf'
#define isinf(__x)      __isinf(__x)
                        ^
/usr/include/c++/cmath:403:12: note: in instantiation of function template specialization '__libcpp_isinf<double>' requested here
    return __libcpp_isinf((typename std::__promote<_A1>::type)__lcpp_x);
           ^
/usr/work/www/firefox/work/firefox-68.0.2/mfbt/decimal/Decimal.cpp:698:14: note: in instantiation of function template specialization 'isinf<double>' requested here
    if (std::isinf(doubleValue))
             ^
1 error generated.
gmake[3]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/rules.mk:828: Decimal.o] Error 1
gmake[3]: Leaving directory '/usr/work/www/firefox/work/build/mfbt'
gmake[2]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/recurse.mk:74: mfbt/target] Error 2
gmake[2]: Leaving directory '/usr/work/www/firefox/work/build'
gmake[1]: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/recurse.mk:34: compile] Error 2
gmake[1]: Leaving directory '/usr/work/www/firefox/work/build'
gmake: *** [/usr/work/www/firefox/work/firefox-68.0.2/config/rules.mk:413: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/www/firefox
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/www/firefox

Comment 2

[Daniel Bodea [:danibodea]]

This bug got the (Firefox Build System) General: Unsupported Platforms component set. If incorrect, please set a more appropriate one, rather than resetting it to the Untriaged or General one. Thank you.