157459 - need way to set default setup type for linux

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Jeremy M. Dolan]

I only deal with browser stuff, so I do a custom install nightly builds every
day, and have to select custom, then browser and PSM only, day in, and day out.
Then I have to manually type in /opt/mozilla/20020714 every time.

If I could automate this with a config file or command line options, it would be
very nice.

In this mode, X would not even be required. Something like:

./mozilla-installer --packages xpcom.xpi,browser.xpi,psm.xpi,deflenus.xpi...
--destdir /opt/mozilla/20020714

Then I could have a script generate the yearmonthday bit, and save myself a good
5 mintues every morning. (30 hours a year per person who would benefit from
this... I'm sure some others would be interested)

Comment 1

[Andrew Schultz]

./mozilla-installer -ma
will install with defaults without user intervention.
"-ms" is supposed to do the same except show no UI.  that doesn't work.

you *can* set the defaults in a file - config.ini.

Comment 2

[Daniel Veditz [:dveditz]]

This doesn't meet Jerry's requirements on two counts, X is still required and
he'd get the default install directory instead of a date-based directory. If
using X is OK then the second objection could be overcome with a simple
pre-processing script to change the "Default location=" line in the config.ini
before running the install with -ma

Hm, I don't see a way to set the default setup type. In windows there's a
setting you can change in the config.ini for that. If there were you'd want to
set it to "Setup Type2" to get navigator-only (with PSM).

I'm pretty sure this is a dupe, in any case it's not something Netscape is going
to pay me to work on so marking helpwanted.

You may be able to find some of the scripts and packages around (not sure
where... ask on n.p.m.builds) to get and install a daily build, but I don't know
if they use the .xpi packages.

Comment 3

[Andrew Schultz]

> X is still required

the "-ms" argument is parsed, but ignored by the unix wizard.  I think I've
managed to hack a working mozilla-installer-bin that handles "-ms".  I filed bug
157672 for that as it seems to be a (somewhat) independent issue from this one.

Comment 4

[Andrew Schultz]

Attachment: patch

patch to parse and handle "Default Setup Type" for unix.

this does not affect interactive install because I don't know how to change the
initial GTK selection.

Comment 5

[Jeremy M. Dolan]

There is no -help that a user might discover -ms and -ma.

Comment 6

[Andrew Schultz]

you're forgetting lxr, Mozilla's extensive online help system:
http://lxr.mozilla.org/mozilla1.0/source/xpinstall/wizard/unix/src2/nsXInstaller.cpp#41

worksforme, but filed bug 158033 anyway.  :)

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 91598 [details] [diff] [review]
patch

r=dveditz

Comment 8

[Jeremy M. Dolan]

This patch has sat for 5 months. Who needs to sr?

Comment 9

[Matthias Versen [:Matti]]

[e-mail]: 
Can we use your r= as sr= ?
And Do you know someone who can r= this ?

Comment 10

[Andrew Schultz]

-> me

Comment 11

[Alexander Opitz]

@Andrew does this patch cleanly apply to cirrent trunk?

Comment 12

[Andrew Schultz]

Attachment: patch v2

New in this patch:

1. it uses "Typical/Complete/Navigator..." for the "Setup Type" instead of
"Setup Type0/Setup Type1/Setup Type2...".
2. I've included modifications to the sample config.ini.
3. I figured out how to set the active button in gtk, so the patch now works
outside of auto and silent mode.

Comment 13

[Andrew Schultz]

Comment on attachment 140290 [details] [diff] [review]
patch v2

dveditz, this is similar to a previous patch you gave r=dveditz on.  This patch
is even better.  :)

Comment 14

[Andrew Schultz]

Attachment: patch v2 +cleanup

this is the same patch with a touch of cleanup (I couldn't resist!).  the 1st
radio button is handled almost identically to the rest of the radio buttons,
and does not need its own piece of code.

Comment 15

[Alexander Opitz]

@Andrew

You should mark the bug as assigned if you want to fix it with your patch :-)
Also other peoples know then, that you work on it.

Comment 16

[Andrew Schultz]

Attachment: include config.it changes

Comment 17

[Andrew Schultz]

Comment on attachment 141869 [details] [diff] [review]
include config.it changes

ugh. this is bitrotted.

Comment 18

[Andrew Schultz]

Attachment: patch merged to trunk

note that the config.ini syntax I implemented is different than that used in
Windows.

this patch:
Default Setup Type=Typical
windows:
Default Setup Type=Setup Type 0

implementing it the windows way would be just as easy, but using the short
description seems better, at least as long as the "name" of the setup type is
so non-descriptive.

Comment 19

[Andrew Schultz]

Attachment: the patch I meant to attach

I think this bug is cursed.

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 147102 [details] [diff] [review]
the patch I meant to attach

>+; *** LOCALIZE ME BABY ***
>+Default Setup Type=Typical

Add a comment above the "localize me" comment documenting that the value for
default setup type value must exactly match the "Description Short" of the
desired setup type.

r=dveditz

Comment 21

[Andrew Schultz]

fixed