1574693 - Port |Bug 1161599 - Show "Reload Image" if the image has an error| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Ian Neal]

Simple port of Bug 1161599

Comment 1

[Ian Neal]

Attachment: Reload image patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Some broken images cannot be reloaded
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9086214 [details] [diff] [review]
Reload image patch

r/a=me

I wonder if it wouldn't make sense to combine this.onLoadedImage with this.onCompletedImage e.g. does not make much sense to set an image in error as desktop background but basically this is now how it is done in browser too.

Comment 3

[Ian Neal]

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

I wonder if it wouldn't make sense to combine this.onLoadedImage with
this.onCompletedImage e.g. does not make much sense to set an image in error
as desktop background but basically this is now how it is done in browser
too.

Spun into Bug 1578084

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f76b01af132e
Port |Bug 1161599 - Show "Reload Image" if the image has an error| to SeaMonkey. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/b7bdeca19a2a6f6ed2e72d377ab2babe1a59bae7

Comment 6

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/408869f11d9e9026b287f6dd8a3ae2561cf07c65