Closed Bug 1574693 Opened 1 year ago Closed 1 year ago

Port |Bug 1161599 - Show "Reload Image" if the image has an error| to SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

enhancement
Not set
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

RESOLVED FIXED
seamonkey2.68
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file)

Simple port of Bug 1161599

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Some broken images cannot be reloaded
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Attachment #9086214 - Flags: review?(frgrahl)
Attachment #9086214 - Flags: approval-comm-release?
Attachment #9086214 - Flags: approval-comm-esr60?
Comment on attachment 9086214 [details] [diff] [review]
Reload image patch

r/a=me

I wonder if it wouldn't make sense to combine this.onLoadedImage with this.onCompletedImage e.g. does not make much sense to set an image in error as desktop background but basically this is now how it is done in browser too.
Attachment #9086214 - Flags: review?(frgrahl)
Attachment #9086214 - Flags: review+
Attachment #9086214 - Flags: approval-comm-release?
Attachment #9086214 - Flags: approval-comm-release+
Attachment #9086214 - Flags: approval-comm-esr60?
Attachment #9086214 - Flags: approval-comm-esr60+
Blocks: 1578061
Status: NEW → ASSIGNED
Blocks: 1578084

(In reply to Frank-Rainer Grahl (:frg) from comment #2)

I wonder if it wouldn't make sense to combine this.onLoadedImage with
this.onCompletedImage e.g. does not make much sense to set an image in error
as desktop background but basically this is now how it is done in browser
too.

Spun into Bug 1578084

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f76b01af132e
Port |Bug 1161599 - Show "Reload Image" if the image has an error| to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.