1574879 - The "breach" warning icon is displayed for all the saved logins when refreshing the "about:logins" page

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: breach warning.gif

[Affected Versions]:

• Nightly 70.0a1

[Affected Platforms]

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with multiple saved logins.

[Steps to reproduce]:

1. Open the latest Nightly browser with the profile from prerequisites.
2. Navigate to "about:logins" page.
3. Refresh the page.
4. While the page is refreshed observe the saved logins.

[Expected results]:

• The saved logins are correctly displayed and the "Breach" warning icon is not displayed.

[Actual results]:

• The "Breach" warning icon is displayed for all the saved logins.

[Regression]

• The issue is not reproducible with older Nightly 70.0a1 builds. Considering this, using mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
• Pushlog: https://tinyurl.com/yxzgdlba
• Last good revision: f510b32aec3a54efcf58e16f5c5813e2809dd901
• First bad revision: 2a6b7a24fdb3e082e98563107dfae018cb02ebe3

From this pushlog it seems that bug 1569846 introduced this behavior.

[Notes]:

• Attached a screen recording with the issue.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:cosmin.muntean, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 2

[Matthew N. [:MattN]]

I have also noticed this.

Comment 3

[Lesley Norton [:lnorton]]

Attachment: Bug 1574879: Fix breach warning icon flickering on about:logins page refreshes. r=mattn

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12940bc840cb
Fix breach warning icon flickering on about:logins page refreshes. r=MattN

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/12940bc840cb

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-22) (64-bit) on Windows 7, MacOS 10.14 and Ubuntu 16.04.

• The "Breach" warning icon is no longer displayed while refreshing the page.