1569846 - Add dismissal UI to breach-alert box in about:logins

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Luke Crouch [:groovecoder]]

In https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/357432646, the UI includes an "x" to dismiss the breach alert. Context:

"The breach dialog is dismissible, in case the user chooses to ignore the warning, or if they've already changed the password and just haven't saved an updated record."

Comment 1

[Luke Crouch [:groovecoder]]

Transposing comment from :MattN on Bug 1569847 ...

Should this Sync across devices? Storing a timestamp of when it was dismissed would probably be fine (the timestamp is necessary to handle a future breach on the same domain). If we store this on the login it's easier to sync but we also have to be careful to make sure the Sync code will merge records properly if a login changes on a device which doesn't have them (e.g. iOS, Android, old Fx desktop, etc.) and we'd probably need to ask the Sync team to help with that, at least for testing our changes.

:lnorton, :betsymi, rgaddis, ssage - what's the best UX for this?

Comment 2

[Betsy Mikel [:betsymi]]

I'm not fully understanding the request. Any more context to add :lnorton, :rgaddis, :ssage or :groovecoder?

Comment 3

[Lesley Norton [:lnorton]]

Attachment: Bug 1569846: Add breach alert dismissal. r=mattn

Comment 4

[Luke Crouch [:groovecoder]]

(In reply to Betsy Mikel [:betsymi] from comment #2)

I'm not fully understanding the request. Any more context to add :lnorton, :rgaddis, :ssage or :groovecoder?

If a user dismisses a breach alert on desktop, should it be dismissed on all devices? (When we show breach alerts on other devices.)

Comment 5

[rgaddis]

If a user dismisses a breach alert on desktop, should it be dismissed on all devices? (When we show breach alerts on other devices.)

Yes, I believe that would be a reasonable user expectation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9acadba3a61
Add breach alert dismissal. r=MattN,fluent-reviewers,flod

Comment 7

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1569846, Bug 1572118) for causing failures in browser_deleteLogin.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/eb56d88d1b0758babf0ba4ac55fe261481833f09

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C7%2Cshippable%2Copt%2Cmochitests%2Ctest-windows7-32-shippable%2Fopt-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29&fromchange=a3480699468f683ae6f045828ccf54c6590e9815&tochange=eb56d88d1b0758babf0ba4ac55fe261481833f09&group_state=expanded&selectedJob=261717736

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261717736&repo=autoland&lineNumber=3199

[task 2019-08-15T03:20:12.897Z] 03:20:12 INFO - Console message: [JavaScript Warning: "Sending message that cannot be cloned. Are you trying to send an XPCOM object?" {file: "resource://testing-common/ContentTask.jsm" line: 78}]
[task 2019-08-15T03:20:12.897Z] 03:20:12 INFO - Buffered messages finished
[task 2019-08-15T03:20:12.898Z] 03:20:12 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_deleteLogin.js | Uncaught exception - Waiting for logins to be displayed - timed out after 50 tries.
[task 2019-08-15T03:20:12.898Z] 03:20:12 INFO - Leaving test bound test_show_logins
[task 2019-08-15T03:20:12.898Z] 03:20:12 INFO - Entering test bound test_login_item
[task 2019-08-15T03:20:12.898Z] 03:20:12 INFO - Clicking on the first login
[task 2019-08-15T03:20:12.898Z] 03:20:12 INFO - GECKO(1588) | console.warn: LoginHelper: "Couldn't parse origin for" "" ({})
[task 2019-08-15T03:20:12.937Z] 03:20:12 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_deleteLogin.js | The login item should get populated - true == true -
[task 2019-08-15T03:20:12.952Z] 03:20:12 INFO - GECKO(1588) | JavaScript error: chrome://browser/content/aboutlogins/components/login-list.js, line 324: TypeError: this._logins[login.guid] is undefined
[task 2019-08-15T03:20:12.952Z] 03:20:12 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_deleteLogin.js | Should not be in no logins view as there is still one login - true == true -
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_deleteLogin.js | Should not be in no logins view as there is still one login - true == true -
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - Console message: [JavaScript Error: "TypeError: this._logins[login.guid] is undefined" {file: "chrome://browser/content/aboutlogins/components/login-list.js" line: 324}]
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - loginRemoved@chrome://browser/content/aboutlogins/components/login-list.js:324:5
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - @chrome://browser/content/aboutlogins/aboutLogins.js:51:27
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - sendToContent@resource:///actors/AboutLoginsChild.jsm:197:18
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - receiveMessage@resource:///actors/AboutLoginsChild.jsm:173:14
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - receiveMessage@resource://gre/modules/ActorManagerChild.jsm:179:30
[task 2019-08-15T03:20:12.953Z] 03:20:12 INFO - MessageListener.receiveMessageinit@resource://gre/modules/ActorManagerChild.jsm:67:15
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - init@resource://gre/modules/ActorManagerChild.jsm:215:11
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - onNewDocument@resource://gre/modules/ActorManagerChild.jsm:320:67
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - MozDocumentCallback.onNewDocumentinit@resource://gre/modules/ActorManagerChild.jsm:309:21
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - @resource://gre/modules/ActorManagerChild.jsm:349:19
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - @chrome://global/content/browser-content.js:14:41
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO -
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - GECKO(1588) | console.warn: LoginHelper: "Couldn't parse origin for" "" ({})
[task 2019-08-15T03:20:12.954Z] 03:20:12 INFO - Clicking on the first login
[task 2019-08-15T03:20:13.053Z] 03:20:13 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_deleteLogin.js | The login item should get populated - true == true -

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2a6b7a24fdb3
Add breach alert dismissal. r=MattN,fluent-reviewers,flod

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2a6b7a24fdb3