1575088 - "Permissions Set" blue-dot is stretched vertically, in site-info doorhanger

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot

STR:

1. Visit some site where you have permissions set.
   (For example: https://www.google.com/maps/ , click the "dot" in lower right corner, and click the checkbox for "Remember this decision" and then the button to Allow Location Access")

2. Click the Site ID button (the lock icon at left edge of URL bar)

3. Look at the "Permissions Set" area

ACTUAL RESULTS:
The blue circle icon (to the right of "Permissions Set") is stretched vertically, so it's an awkward oval shape.

EXPECTED RESULTS:
It should be a circle.

The issue might be OS-specific (by virtue of depending on the size of the "Permissions Set" text). I'm on Linux, if it matters.

It looks like the icon is a XUL <image> that has this styling:

list-style-image: url(chrome://browser/skin/badge-blue.svg);
width: 16px;
height: 16px;

...but it's inside of an hbox alongside a label, so it actually gets stretched to the height of the label.

There are several possible fixes:

• Give its hbox parent -moz-box-align: start so that it doesn't stretch its kids in the cross axis.
• Wrap the image in a wrapper box which can be the thing that gets stretched (instead of the image)
• ...or maybe there's something else that is more elegant & would also work.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: narrower screenshot

Comment 2

[Tim Huang[:timhuang]]

Thanks Daniel, I will work on this.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1575088 - Fix the style issue of the permission granted indicator. r?johannh!

This patch fixes the style issue by make the container of the permission
granted indicator to centered align its children.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57991c0539e4
Fix the style issue of the permission granted indicator. r=johannh

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/57991c0539e4

Comment 6

[Daniel Holbert [:dholbert]]

Thanks for the quick action!

Comment 7

[Tim Huang[:timhuang]]

Hi Daniel,

Would you be able to verify the bug? Thanks.

Comment 8

[Daniel Holbert [:dholbert]]

Sure! I think tomorrow's nightly is the first one that'll have the fix, so I'll take a look then.

(The latest nightly still shows the issue, but I think that makes sense, given how recently the fix hit mozilla-central.)

Comment 9

[Daniel Holbert [:dholbert]]

Verified - this looks good in Nightly 70.0a1 (2019-08-21) (64-bit)

Comment 10

[Tim Huang[:timhuang]]

Thanks!!