1575305 - Some ColumnSet clean up

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

While working on bug 1575106, I accumulate some cleanup patches that affect no functionality. This is the bug for reviewing them.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575305 Part 1 - Remove an unneeded condition used for ::-moz-column-content.

Before bug 1411422, a ::-moz-column-content has height:100%, so it could
go into this path if ColumnSet's available block-size is unconstrained.

However, after bug 1411422, height:100% was removed for
::-moz-column-content. That is, its computed block-size is
unconstrained, so it can't go into this path. This applies regardless of
whether column-span is enabled or not.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575305 Part 2 - Remove the unused border-padding variable in nsBlockFrame::FindBestBalanceBSize().

Depends on D42708

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575305 Part 3 - Initialize colBSize with available block-size when column-span is enabled.

nsBlockFrame already prepares the available block-size for
ColumnSetFrame with ColumnSetWrapper's block-size and max-block-size
applied. (ColumnSet's computed block-size and max block-size is always
unconstrained when column-span is enabled.)

Depends on D42709

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575305 Part 4 - Improve column set log.

1. Add this to the log so that it's easier to debug a nested column
   balancing

2. Print the struct fields the same as their names.

Depends on D42710

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f9187f13c5d3
Part 1 - Remove an unneeded condition used for ::-moz-column-content. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/d786ae0b7dd3
Part 2 - Remove the unused border-padding variable in nsBlockFrame::FindBestBalanceBSize(). r=dbaron
https://hg.mozilla.org/integration/autoland/rev/7f6f92f75e01
Part 3 - Initialize colBSize with available block-size when column-span is enabled. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/af26c6064d12
Part 4 - Improve column set log. r=dbaron

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/f9187f13c5d3
https://hg.mozilla.org/mozilla-central/rev/d786ae0b7dd3
https://hg.mozilla.org/mozilla-central/rev/7f6f92f75e01
https://hg.mozilla.org/mozilla-central/rev/af26c6064d12