Some ColumnSet clean up
Categories
(Core :: Layout: Columns, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(4 files)
While working on bug 1575106, I accumulate some cleanup patches that affect no functionality. This is the bug for reviewing them.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Before bug 1411422, a ::-moz-column-content has height:100%, so it could
go into this path if ColumnSet's available block-size is unconstrained.
However, after bug 1411422, height:100% was removed for
::-moz-column-content. That is, its computed block-size is
unconstrained, so it can't go into this path. This applies regardless of
whether column-span is enabled or not.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D42708
|
|
Assignee | |
Comment 3•5 years ago
|
||
nsBlockFrame already prepares the available block-size for
ColumnSetFrame with ColumnSetWrapper's block-size and max-block-size
applied. (ColumnSet's computed block-size and max block-size is always
unconstrained when column-span is enabled.)
Depends on D42709
|
|
Assignee | |
Comment 4•5 years ago
|
||
-
Add
thisto the log so that it's easier to debug a nested column
balancing -
Print the struct fields the same as their names.
Depends on D42710
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f9187f13c5d3 Part 1 - Remove an unneeded condition used for ::-moz-column-content. r=dbaron https://hg.mozilla.org/integration/autoland/rev/d786ae0b7dd3 Part 2 - Remove the unused border-padding variable in nsBlockFrame::FindBestBalanceBSize(). r=dbaron https://hg.mozilla.org/integration/autoland/rev/7f6f92f75e01 Part 3 - Initialize colBSize with available block-size when column-span is enabled. r=dbaron https://hg.mozilla.org/integration/autoland/rev/af26c6064d12 Part 4 - Improve column set log. r=dbaron
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f9187f13c5d3
https://hg.mozilla.org/mozilla-central/rev/d786ae0b7dd3
https://hg.mozilla.org/mozilla-central/rev/7f6f92f75e01
https://hg.mozilla.org/mozilla-central/rev/af26c6064d12
Description
•