Closed Bug 1411422 Opened 2 years ago Closed 6 months ago
Skip pseudo-styled parents when calculating percentage height/width in multicol container
Bug 1411422 - Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content.
47 bytes, text/x-phabricator-request
|Details | Review|
Currently there is a workaround in UA.css for pseudo-styles like '-moz-column-content' that use 'height: 100%' so that when resolving percentage heights, the pseudo styled parent will have a valid percentage height defined for it. This was a reasonable workaround assuming that only one such pseudo-styled child will exist under a parent and therefore it can take up 100% of its parent's height. But, with the proposed implementation for Column-Span this is not true anymore since the new ColumnSetWrapperFrame can have multiple pseudo-styled ColumnSetFrames and ColumnSpanWrappers inside it. So, we must change the code that is calculating this percentage height to hop over any parents with pseudo-styles. I believe, the same applies for percentage width calculation.
Component: Layout → Layout: Columns
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c4f25a740b96 Make percentage block size children work without "height:100%" in ::-moz-column-set and ::-moz-column-content. r=dbaron
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16483 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.