Closed Bug 1575326 Opened 2 years ago Closed 1 year ago

Fix usage of nsIDocShellTreeItem in nsDocShell::SetIsActive

Categories

(Core :: DOM: Navigation, enhancement, P2)

Product:
Core
Component:
DOM: Navigation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Project Flags:
Fission Milestone M6
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: djvj, Assigned: tetsuharu)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:simple])

Attachments

(1 file)

Bug 1575326 - Fix usage of nsIDocShellTreeItem in nsDocShell::SetIsActive.
47 bytes, text/x-phabricator-request
Details | Review

https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#5272

This code checks if the current docshell is the root (i.e. same-type parent is null), and if so updates the screen orientation lock. This may trigger spuriously post-fission where a parent is out-of-process and the parent docshell is null.

The determination of whether this docshell is root should be made using the corresponding BrowsingContext tree, as opposed to the docshell tree directly.

Component: DOM: Core & HTML → Document Navigation
Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:simple]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Depends on: 1606528
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b531d7b11929
Fix usage of nsIDocShellTreeItem in nsDocShell::SetIsActive. r=kmag

https://hg.mozilla.org/mozilla-central/rev/b531d7b11929

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.