Closed
Bug 1575326
Opened 5 years ago
Closed 4 years ago
Fix usage of nsIDocShellTreeItem in nsDocShell::SetIsActive
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: djvj, Assigned: tetsuharu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [rm-docshell-tree-item:simple])
Attachments
(1 file)
https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#5272
This code checks if the current docshell is the root (i.e. same-type parent is null), and if so updates the screen orientation lock. This may trigger spuriously post-fission where a parent is out-of-process and the parent docshell is null.
The determination of whether this docshell is root should be made using the corresponding BrowsingContext tree, as opposed to the docshell tree directly.
|
||
Updated•5 years ago
|
Component: DOM: Core & HTML → Document Navigation
|
||
Updated•5 years ago
|
Fission Milestone: --- → M5
Priority: -- → P2
|
Reporter | |
Updated•5 years ago
|
Whiteboard: [rm-docshell-tree-item:simple]
|
|
||
Updated•5 years ago
|
Fission Milestone: M5 → Future
|
||
Comment 1•5 years ago
|
||
Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).
Fission Milestone: Future → M6
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
Pushed by tetsuharu.ohzeki@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b531d7b11929 Fix usage of nsIDocShellTreeItem in nsDocShell::SetIsActive. r=kmag
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•