Closed
Bug 1606528
Opened 6 years ago
Closed 6 years ago
Implement BrowsingContext::IsTop()
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla74
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: tetsuharu, Assigned: tetsuharu)
References
Details
Attachments
(2 files)
I saw !bc->GetParent() frequently as checking whether it is a root or not.
I feel it's time to add BrowsingContext::IsRoot().
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
This is a frequent pattern.
|
||
Updated•6 years ago
|
Assignee: nobody → tetsuharu.ohzeki
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•6 years ago
|
Summary: Implement BrowsingContext::IsRoot() → Implement BrowsingContext::IsTop()
|
|
||
Updated•6 years ago
|
Attachment #9118260 -
Attachment description: Bug 1606528 - Implement BrowsingContext::IsRoot(). → Bug 1606528 - part 1: Implement BrowsingContext::IsTop().
|
|
Assignee | |
Comment 2•6 years ago
|
||
Pushed by tetsuharu.ohzeki@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ed6e04433ec5
part 1: Implement BrowsingContext::IsTop(). r=kmag
https://hg.mozilla.org/integration/autoland/rev/ba45d2a12dc1
part 2: Replace idioms with BrowsingContext::IsTop(). r=kmag
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed6e04433ec5
https://hg.mozilla.org/mozilla-central/rev/ba45d2a12dc1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox74:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in
before you can comment on or make changes to this bug.
Description
•