1575425 - Support [AllowShared]

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement, P2)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

[AllowShared] allows IDL operations to receive SharedArrayBuffer-backed buffer source types, and thus required for SharedArrayBuffer uses.

Comment 1

[Anne (:annevk)]

In a way this is a duplicate of bug 1231687, but it's also much clearer...

Comment 3

[Anne (:annevk)]

Edgar, is this something you could take this on? (The priority comes from the duplicate and because this is important for eventually shipping SharedArrayBuffer support.)

Comment 4

[Edgar Chen [:edgar]]

Yes, I could take this one.

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfa9719a67e7c5e4566efd2fcb6893949969b87c

Comment 6

[Anne (:annevk)]

Edgar, we should probably also clean up some of the code of https://hg.mozilla.org/mozilla-central/rev/91fe35e7df1fa3124c266c249ad0907320dfd956. E.g., Crypto::GetRandomValues will now be checked at the IDL layer so there's no need for it to throw inline, right? Similarly, the TypedArray bindings setup described there is no longer needed as we get safety from the IDL layer so we know if we can be dealing with shared beyond that and there's no need for two explicit APIs. (Edit: I guess an exception here is APIs that use any, such as postMessage(), but we need to check those either way as treating a SharedArrayBuffer as an empty buffer is wrong too.)

Comment 7

[Edgar Chen [:edgar]]

(In reply to Anne (:annevk) from comment #6)

Edgar, we should probably also clean up some of the code of https://hg.mozilla.org/mozilla-central/rev/91fe35e7df1fa3124c266c249ad0907320dfd956. E.g., Crypto::GetRandomValues will now be checked at the IDL layer so there's no need for it to throw inline, right?

Yes, we could drop those inline checks in this bug, I would think.

Similarly, the TypedArray bindings setup described there is no longer needed as we get safety from the IDL layer so we know if we can be dealing with shared beyond that and there's no need for two explicit APIs. (Edit: I guess an exception here is APIs that use any, such as postMessage(), but we need to check those either way as treating a SharedArrayBuffer as an empty buffer is wrong too.)

And I plan to do TypedArray clean up in a follow-up bug.

Comment 8

[Anne (:annevk)]

(Removing "resab" as blocker to make that bug's immediate dependencies less cluttered. This still remains important for shipping SharedArrayBuffer (without postMessage() support) to release in 75.)

Comment 9

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 1: Remove SharedArrayBuffer type in WebIDL parser;

There is no SharedArrayBuffer type defined in WebIDL spec.

Comment 10

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 2: Merge ArrayBuffer and SharedArrayBuffer in DOM binding;

We need this for upcoming change which supports having [AllowShared] on
ArrayBuffer type in WebIDL.

Comment 11

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 3: Add support for [AllowShared];

Comment 12

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 3-2: Annotate APIs with [AllowShared];

Comment 13

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 4: Remove manually checking shareness in various APIs implmentation;

Now we support [AllowShared] in WebIDL, we don't need to manually check shareness
and throw exception if API don't accept SharedArrayBuffer, the binding will handle
it.

Comment 14

[Edgar Chen [:edgar]]

Attachment: Bug 1575425 - Part 5: Remove DataAllowShared and LengthAllowShared from TypedArray bindings;

There's no need for two explicit APIs as we get safety from the IDL layer. And
treating a SharedArrayBuffer as an empty buffer is wrong too.

Comment 15

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cec9af626ae8722b19894ee2bc5c3ed6649ed932

Comment 16

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&tier=1&revision=7abde937d03b9d9eb768698b793698b58f444c90&selectedJob=285715368

Comment 17

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=f338c3fdf856f098597f929111fabe8ec396436b&group_state=expanded

Comment 18

[Edgar Chen [:edgar]]

Central as Beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8510a327ee79b94f130e852f224eb5fa192e5c0c

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76604cb38aad
Part 1: Remove SharedArrayBuffer type in WebIDL parser; r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/81b22b1796a6
Part 2: Merge ArrayBuffer and SharedArrayBuffer in DOM binding; r=bzbarsky,jwalden
https://hg.mozilla.org/integration/autoland/rev/285f272135f4
Part 3: Add support for [AllowShared]; r=bzbarsky,jwalden
https://hg.mozilla.org/integration/autoland/rev/8cf423865978
Part 4: Remove manually checking shareness in various APIs implmentation; r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/f2b77060cc80
Part 5: Remove DataAllowShared and LengthAllowShared from TypedArray bindings; r=bzbarsky

Comment 20

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/76604cb38aad
https://hg.mozilla.org/mozilla-central/rev/81b22b1796a6
https://hg.mozilla.org/mozilla-central/rev/285f272135f4
https://hg.mozilla.org/mozilla-central/rev/8cf423865978
https://hg.mozilla.org/mozilla-central/rev/f2b77060cc80