Open
Bug 1575506
Opened 5 years ago
Updated 1 year ago
[meta] Turn on builtinGlobals for ESLint's no-redeclare rule for module files
Categories
(Developer Infrastructure :: Lint and Formatting, task, P3)
Developer Infrastructure
Lint and Formatting
Tracking
(Not tracked)
NEW
People
(Reporter: standard8, Unassigned)
References
Details
(Keywords: meta)
Attachments
(1 obsolete file)
After the upgrade to ESLint 6, we have support for checking for redeclare of built-in globals in the global scope.
To make the upgrade easiler, this was turned off, however, after the upgrade, we should be able to turn it on at least for .jsm scope.
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
Reporter | |
Comment 1•2 years ago
|
||
Note: for ES modules, we would need "no-shadow": ["error", { builtinGlobals: true }], because the global scope is treated differently in modules.
Summary: [meta] Turn on builtinGlobals for ESLint's no-redeclare rule for jsm files → [meta] Turn on builtinGlobals for ESLint's no-redeclare rule for module files
|
|
Reporter | |
Comment 2•1 year ago
|
||
|
||
Updated•1 year ago
|
Assignee: nobody → standard8
Status: NEW → ASSIGNED
|
|
||
Comment 3•1 year ago
|
||
Comment on attachment 9317039 [details]
Bug 1575506 - Fix ESLint raised issues with no-shadow of builtinGlobals in toolkit .mjs files. r?Gijs!
Revision D169462 was moved to bug 1812098. Setting attachment 9317039 [details] to obsolete.
Attachment #9317039 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•1 year ago
|
Assignee: standard8 → nobody
Status: ASSIGNED → NEW
You need to log in
before you can comment on or make changes to this bug.
Description
•