1575506 - [meta] Turn on builtinGlobals for ESLint's no-redeclare rule for module files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

After the upgrade to ESLint 6, we have support for checking for redeclare of built-in globals in the global scope.

To make the upgrade easiler, this was turned off, however, after the upgrade, we should be able to turn it on at least for .jsm scope.

Comment 1

[Mark Banner (:standard8)]

Note: for ES modules, we would need "no-shadow": ["error", { builtinGlobals: true }], because the global scope is treated differently in modules.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1575506 - Fix ESLint raised issues with no-shadow of builtinGlobals in toolkit .mjs files. r?Gijs!

Comment 3

[Phabricator Automation]

Comment on attachment 9317039 [details]
Bug 1575506 - Fix ESLint raised issues with no-shadow of builtinGlobals in toolkit .mjs files. r?Gijs!

Revision D169462 was moved to bug 1812098. Setting attachment 9317039 [details] to obsolete.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1575506 - Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r?#frontend-codestyle-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c963e72cf06
Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing node newtab failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/26f637a20dc180da705cb962f1c6acc84cd98277

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | bundles | about:asrouter bundle out of date

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a39a42b27b48
Enable ESLint rule no-redeclare with builtinGlobals on all module and worker files. r=frontend-codestyle-reviewers,devtools-reviewers,nchevobbe,mossop

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a39a42b27b48