Closed Bug 1810567 Opened 2 months ago Closed 2 months ago

Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs)

Categories

(Toolkit :: General, task, P3)

Product:
Toolkit
Component:
General
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1810567 - Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs). r?Gijs!
48 bytes, text/x-phabricator-request
Details | Review

With various new .mjs files being created, I think now would be a good time to turn on no-shadow for them. Overall, I'd like to turn on checking against builtin globals as well (bug 1575506), but this is a intermediate first step.

I think no-shadow is a good rule to help us avoid confusion and possible bugs arising from that confusion.

For now we'll skip .sys.mjs as well, as that is a larger project and has impacts on migrations.

Note: we already have no-shadow turned on for various components and tests across the tree, including the whole of browser/.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/faf422b8e808
Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs). r=Gijs

https://hg.mozilla.org/mozilla-central/rev/faf422b8e808

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Blocks: 1812098
You need to log in before you can comment on or make changes to this bug.