Closed
Bug 1810567
Opened 11 months ago
Closed 11 months ago
Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs)
Categories
(Toolkit :: General, task, P3)
Toolkit
General
Tracking
()
RESOLVED
FIXED
111 Branch
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
With various new .mjs
files being created, I think now would be a good time to turn on no-shadow
for them. Overall, I'd like to turn on checking against builtin globals as well (bug 1575506), but this is a intermediate first step.
I think no-shadow
is a good rule to help us avoid confusion and possible bugs arising from that confusion.
For now we'll skip .sys.mjs
as well, as that is a larger project and has impacts on migrations.
Assignee | ||
Comment 1•11 months ago
|
||
Note: we already have no-shadow
turned on for various components and tests across the tree, including the whole of browser/
.
Assignee | ||
Comment 2•11 months ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/faf422b8e808 Enable ESLint rule no-shadow for .mjs files (but not .sys.mjs). r=Gijs
Comment 4•11 months ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•