1575820 - The "First Run Triplets" are not displayed on the first tab opened after logging in to "Firefox Sync"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 69.0b15 - Build ID: 20190819184224
• Firefox Nightly 70.0a1 - Build ID: 20190821215524

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have a new Firefox profile;
• Have valid FxA credentials.
• You are not logged in to "Firefox Sync".

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and click the "Firefox Account" toolbar button.
2. Click the "Turn on Sync..." button and enter your credentials.
3. Open a "New Tab" and observe the behavior.

[Expected result]:

• The page is successfully opened and the "First Run Triplets" are displayed at the top of the page.

[Actual result]:

• The "First Run Triplets" are not displayed at all.

[Notes]:

• The "First Run Triplets" will be displayed again on the next opened tab.
• Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5296

Comment 2

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: "First Run Triplets" are not displayed on the first tab and previously opened tab after logging in to "Firefox Sync"

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/eb7346d52181

Comment 4

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (71.0a1 Build ID - 20190911095413) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, the "First Run Triplets" are successfully displayed on the first tab opened after logging in to "Firefox Sync".

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift to beta?

Comment 6

[Ed Lee :Mardak]

Attachment: Bug 1575820 - The "First Run Triplets" are not displayed on the first tab opened after logging in to "Firefox Sync"

https://github.com/mozilla/activity-stream/commit/104659d936ab4b2804ae873fb0fef6c5ddda9d4d

Comment 7

[Punam Dahiya [:pdahiya]]

Comment on attachment 9092234 [details]
Bug 1575820 - The "First Run Triplets" are not displayed on the first tab opened after logging in to "Firefox Sync"

Beta/Release Uplift Approval Request

• User impact if declined: After sync successful login, user will not see triplet cars on first opened and existing open new tabs.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See #comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small patch that's verified in nightly by QA
• String changes made/needed: None

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9092234 [details]
Bug 1575820 - The "First Run Triplets" are not displayed on the first tab opened after logging in to "Firefox Sync"

Let's uplift for beta 7; sounds like we should show these cards to sync users too when this was launched in 69.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f910d35d9d84

Comment 10

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Beta (70.0b7 Build ID - 20190916074538) installed, on Windows 10 x64, Arch Linux and Mac 10.14.6. Now, the "First Run Triplets" are successfully displayed on the first tab opened after logging in to "Firefox Sync".