1575964 - layout/reftests/columns/column-box-alignment-rtl.html fails if column-span is enabled

Status: RESOLVED FIXED

(Core :: Layout: Columns, defect, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See this reftest-analyzer result. (This try run has my WIP patches for bug 1575106, but the test already fails on Nightly (2019-08-22).

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575964 Part 1 - Separate a fixup logic which is redundant if column-span is enabled.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575964 Part 2 - Fix RTL column positions when column-span is enabled.

Since column-content's positions are moved, ColumnSet's overflow areas
needs to be fixed as well.

Depends on D44278

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1575964 Part 3 - Add new reftests for RTL columns, and run them with column-span enabled.

column-box-alignment-rtl-2.html is column-box-alignment-rtl.html plus

body {
  writing-mode: vertical-rl;
}

Depends on D44279

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

cc :heycam in case my patches are relevant to bug 1570039.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/754f6bc92d67
Part 1 - Separate a fixup logic which is redundant if column-span is enabled. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/1278aa29cad0
Part 2 - Fix RTL column positions when column-span is enabled. r=dbaron
https://hg.mozilla.org/integration/autoland/rev/0fe71f31e045
Part 3 - Add new reftests for RTL columns, and run them with column-span enabled. r=dholbert

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/754f6bc92d67
https://hg.mozilla.org/mozilla-central/rev/1278aa29cad0
https://hg.mozilla.org/mozilla-central/rev/0fe71f31e045