Closed Bug 1423383 (enable-column-span-nightly) Opened 7 years ago Closed 5 years ago

Enable pref for column-span (layout.css.column-span.enabled) by default for Nightly only.

Categories

(Core :: Layout: Columns, enhancement, P3)

Product:
Core
Component:
Layout: Columns
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: neerja, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Bug 1423383 - Enable layout.css.column-span.enabled on Nightly.
47 bytes, text/x-phabricator-request
Details | Review 
      No description provided.
Summary: Enable pref for column-span (layout.css.column-span.enabled) by default. → Enable pref for column-span (layout.css.column-span.enabled) by default for Nightly only.
Priority: -- → P1
Priority: P1 → P3
Blocks: column-span
No longer blocks: css-multicol-1
Component: Layout → Layout: Columns
No longer depends on: 1346983
Once this landed in Nightly, it should be mentioned on https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features#column-span.

Sebastian
Keywords: dev-doc-needed
Depends on: ship-column-span
Blocks: ship-column-span
No longer depends on: ship-column-span
Neerja hasn't been active in bugzilla since February 2018.
Assignee: neerjapancholi → nobody
Depends on: 1535200
Depends on: 1547086
Depends on: 1548100
Depends on: 1548118
Depends on: 1548126
Blocks: 1542619
Depends on: 1524431
Depends on: 1523582
Depends on: 1572912
Depends on: 1573329
Alias: enable-column-span-nightly
Depends on: 524431
Depends on: 1570039
No longer depends on: 524431
Depends on: 1575106
No longer depends on: 1570039
Depends on: 1575964
No longer blocks: 1542619
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED

properties-db.js is patched via ./mach devtools-css-db.

Attachment #9084449 - Attachment description: Bug 1423383 - Enable layout.css.column-span.enabled on Nightly. → Bug 1423383 Part 2 - Enable layout.css.column-span.enabled on Nightly.
Attachment #9093377 - Attachment description: Bug 1423383 Part 1 - Update devtools' properties-db.js, and update test expectations. → Bug 1423383 Part 1 - Update devtools' properties-db.js for column-span, and update test expectations.

Are these patches out-of-order?

./mach devtools-css-db makes no changes on a clean up-to-date mozilla-central build, so the commit message in part 1 seems possibly-wrong ("properties-db.js is patched via ./mach devtools-css-db.")

I'm guessing that patch was generated by first building with the pref-flip, and then running the devtools mach command. Which makes me think the patches should be in the opposite order...

Flags: needinfo?(aethanyc)

(Or they should just be folded into a single patch perhaps, since neither patch will pass tests on its own I think.)

Oops, you're right. ./mach devtools-css-db makes no changes if the pref is not flipped first ... I'll fold the two patches into one.

Flags: needinfo?(aethanyc)
Attachment #9084449 - Attachment description: Bug 1423383 Part 2 - Enable layout.css.column-span.enabled on Nightly. → Bug 1423383 - Enable layout.css.column-span.enabled on Nightly.
Attachment #9093377 - Attachment is obsolete: true
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/db7389169402
Enable layout.css.column-span.enabled on Nightly. r=dholbert

https://hg.mozilla.org/mozilla-central/rev/db7389169402

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: