DOM BP: Why paused message should also render related DOM Nodes
Categories
(DevTools :: Debugger, enhancement, P3)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: Honza, Assigned: davidwalsh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp])
Attachments
(2 files)
Why paused message should also render DOM nodes that are related to the DOM mutation event.
-
Subtree modification
The node with BP (parent of the tree)
The added/removed node -
Attribute modification
The node with BP -
Node Removal
The node with BP (the removed one, so highlighting doesn't have to work)
Attaching also screenshots from Chrome. Note that Chrome has a bug in case of subtree-notification (node added). The parent node <ul> is displayed instead of the added child node.
Honza
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Logan, would you be able to outline what you think needs to be done here on the server side? I think this would be fun to tackle while you're gone.
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
You'll want to look at the places we call _breakOnMutation
which I think should make things relatively clear. Those all have access to evt.target
which you'll use as one of the result values.
I guess you'd want to grab the actors for those nodes, and send their IDs as part of the pause payload data via pauseForMutationBreakpoint
. Then you'll need to figure out the right way to convert those IDs to front's in the client side logic.
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by dwalsh@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bbb195b4e238 Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=davidwalsh
Comment 5•5 years ago
|
||
bugherder |
Description
•