Closed Bug 1576145 Opened 3 months ago Closed Last month

DOM BP: Why paused message should also render related DOM Nodes

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: Honza, Assigned: davidwalsh)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [debugger-mvp])

Attachments

(2 files)

Attached image image.png

Why paused message should also render DOM nodes that are related to the DOM mutation event.

  1. Subtree modification
    The node with BP (parent of the tree)
    The added/removed node

  2. Attribute modification
    The node with BP

  3. Node Removal
    The node with BP (the removed one, so highlighting doesn't have to work)


Attaching also screenshots from Chrome. Note that Chrome has a bug in case of subtree-notification (node added). The parent node <ul> is displayed instead of the added child node.

Honza

Priority: -- → P3

Logan, would you be able to outline what you think needs to be done here on the server side? I think this would be fun to tackle while you're gone.

Flags: needinfo?(loganfsmyth)

You'll want to look at the places we call _breakOnMutation which I think should make things relatively clear. Those all have access to evt.target which you'll use as one of the result values.

I guess you'd want to grab the actors for those nodes, and send their IDs as part of the pause payload data via pauseForMutationBreakpoint. Then you'll need to figure out the right way to convert those IDs to front's in the client side logic.

Flags: needinfo?(loganfsmyth)
Whiteboard: [debugger-mvp]
Assignee: nobody → dwalsh
Status: NEW → ASSIGNED
Depends on: 1585902
Attachment #9091564 - Attachment description: Bug 1576145 - Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=jlast → Bug 1576145 - Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=loganfsmyth
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbb195b4e238
Show DOM nodes in for DOM Mutation Breakpoints in WhyPaused block r=davidwalsh
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.