Closed
Bug 1585902
Opened 5 years ago
Closed 5 years ago
Type `paused` event via protocol.js specification and use emit() instead of sendActorEvent
Categories
(DevTools :: Debugger, task, P3)
DevTools
Debugger
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: ochameau, Assigned: loganfsmyth)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
The thread actor is still using old API, pre-protcotol.js to emit a few of its events: sendActorEvent
:
https://searchfox.org/mozilla-central/search?q=sendActorEvent(&case=true®exp=false&path=thread.js
Doing this:
- prevents easily passing actor instances in the payload of these events
- make the thread actor special compare to all other one
Instead it should be using emit
and type each attribute of the event in the thread specification:
https://searchfox.org/mozilla-central/source/devtools/shared/specs/thread.js#27-35
It looks like the specification has already been covered when implementing ThreadFront
,
so it should be mostly about replacing sendActorEvent
by emit
.
Updated•5 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Type: enhancement → task
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → loganfsmyth
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by loganfsmyth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c7777eb19c6e
Use the protocoljs framework for emitting events. r=ochameau
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•