1576150 - Update pageInfo's security tab

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, enhancement)

Description

[Ian Neal]

Port the following:

• Bug 886752 - Show TLS/SSL version in page info dialog
• Bug 1126413 - Part 2: UI changes to display security info on broken secure pages
• Bug 1153010 - Disambiguate error messages for mixed content and weak/broken cipher
• Bug 1250568 - Adding TLS 1.3 to nsISSLStatus
• Bug 1279953 - Ambiguous string usage for "not encrypted page"
• Bug 1305289 - Certificate Transparency - basic UI indicator
• Bug 1320566 - Certificate Transparency - implement CT Policy
• Bug 1354297 - Certificate expiry date is displayed in the page info dialog
• Bug 1195196 - Use proper plural form for number of visits in Page Info
• Bug 1430060 - Hide Security tab in Page Info when you are on about: pages

Also switch to using pippki's strings rather than duplicating them into pageInfo

Comment 1

[Ian Neal]

Attachment: Update security tab in pageinfo

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Missing enhanced functionality
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: lots but all good

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9087709 [details] [diff] [review]
Update security tab in pageinfo

/suite/browser/pageinfo/security.js

> +        certificateTransparency : undefined

NIT: Missing dangling comma. See Bug 1486739

> +  if (!info || uri.scheme === "about") {

Maybe add chrome and other internal schemes too in a follow-up and a new function returning a bool for supported urls?

> +  var owner, verifier, generalPageIdentityString, identityClass, validity;

Matches browser but better to use one line/separate declarations for each var?

Done farther down this way already:
>   var hdr;
>   var msg1;
>   var msg2;

Line 355
>   }
>   else {

NIT Inconsistent formatting with the new else added above. You change everything around it so it think just use "} else {" here too.

Otherwise nice work r/a+ with the nits fixed.

Comment 3

[Frank-Rainer Grahl (:frg)]

NIT Inconsistent formatting with the new else added above. You change everything around it so it think just use "} else {" here too.

Same for

else if (info.encryptionStrength > 0) {
Should be " } else if (info.encryptionStrength > 0) {" I think

Comment 4

[Ian Neal]

Attachment: Update security tab in pageinfo v1.1

Updated to reflect review comments, carrying forward r/a+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/71cb3277328b
Update pageInfo's security tab. r=frg

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/0def45bb7f5de5ae0262c11f228d93bd79d9424a

Comment 7

[Frank-Rainer Grahl (:frg)]

Target 2.53.1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/57329065b977bf8d358f292b41df2901486687b3