1576272 - about:logins loaded with a prepopulated filter to a site with no saved logins shows an unusable screen

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Tim Nguyen :ntim]

Attachment: image.png

STR: Visit about:logins?filter=kdskdsfjhskdjfhlksdaflkadsfasdkjlfsdlkfjasdasfsdfsda

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1576272 - Show the empty-search results view of about:logins if the page is opened with a filter that doesn't match any stored logins. r?MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2a533696457
Show the empty-search results view of about:logins if the page is opened with a filter that doesn't match any stored logins. r=MattN

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c2a533696457

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift? Thanks!

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: prepopulated filter .gif

I have verified this issue on the latest Nightly 71.0a1 (2019-09-08) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.
Now if you navigate to "about:logins" page using a prepopulated filter like in the example provided in comment 0, the following behavior can be observed:

• The "No logins found" message is displayed in the "Login List".
• The "Looking for your saved logins? Set up Sync." page is displayed.

Even if you have other saved logins the "Looking for your saved logins? Set up Sync." page is displayed. From the QA point of view, this might be confusing for the users since they already have other saved logins but the "Looking for your saved logins? Set up Sync." message is displayed. Shouldn't be displayed a different message if the filter returns 0 results? Based on the mock-ups a blank page is displayed if the search returns 0 results.

Attached a screen recording with this behavior.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

The behavior you are seeing was intended by the patch on this bug. Can you please file a bug about showing a blank screen and we can discuss if we want to move forward with that in the new bug?

Comment 7

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Thanks, Jared! I have logged the described behavior in bug 1579852.

Based on comment 5 and comment 6, I will mark this issue as Verified - Fixed.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take this on beta, can you request uplift? Thanks!

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 9089442 [details]
Bug 1576272 - Show the empty-search results view of about:logins if the page is opened with a filter that doesn't match any stored logins. r?MattN

Beta/Release Uplift Approval Request

• User impact if declined: Users who use the "view saved logins" button in the context menu of login forms on websites may end up with an unusable about:logins page
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): This changes how filters are applied to the page. The change is covered by automated tests and has been verified by QA.
• String changes made/needed: none

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089442 [details]
Bug 1576272 - Show the empty-search results view of about:logins if the page is opened with a filter that doesn't match any stored logins. r?MattN

Fix for about:logins in particular situations, helpful for skyline quality.
OK for beta uplift.

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/37a190bdd95c

Comment 12

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Firefox Beta 70.0b6 build on Windows 10 x64, Windows 7 x64, Mac 10.14 and Arch Linux 4.14.