1576390 - Remove gfx.core-animation.enabled pref and all the code that supports the non-CoreAnimation code path

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P5)

Description

[Markus Stange [:mstange]]

Once gfx.core-animation.enabled = true has been baking for a few weeks, I would like to remove the non-CoreAnimation code paths. It's a lot of messy code that I'll be happy to see go away.

I'd like to do this in the 71 cycle, but depending on the number and severity of reported regressions we might want to wait for 72.

Comment 1

[Markus Stange [:mstange]]

I'm going to do this now. CoreAnimation has been shipping on the release channel for a few weeks now and there's no reason to turn it off.
When we want to check whether a given bug was introduced by CA, we can use old builds to test both configurations.

Only having one code path will make it easier to add new functionality which would otherwise need two paths. Bug 1449205 is one example.

Comment 2

[Markus Stange [:mstange]]

mstange@Markuss-MacBook-Pro mozilla % hg log -p -r . | diffstat
 b/gfx/gl/GLContextProviderCGL.mm                 |   15
 b/gfx/layers/opengl/CompositorOGL.cpp            |   10
 b/gfx/webrender_bindings/RenderCompositorOGL.cpp |    9
 b/modules/libpref/init/StaticPrefList.yaml       |   14
 b/widget/cocoa/moz.build                         |    1
 b/widget/cocoa/nsChildView.h                     |  128 --
 b/widget/cocoa/nsChildView.mm                    | 1097 -----------------------
 b/widget/cocoa/nsCocoaWindow.h                   |    2
 b/widget/cocoa/nsCocoaWindow.mm                  |   90 -
 widget/cocoa/RectTextureImage.h                  |   81 -
 widget/cocoa/RectTextureImage.mm                 |  148 ---
 11 files changed, 47 insertions(+), 1548 deletions(-)

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1576390 - Remove the prefs gfx.core-animation.enabled and gfx.compositor.glcontext.opaque, and all the code needed to support it. r=mattwoodrow,jrmuizel,spohl

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1576390 - Remove now-unused DrawWindowOverlay and WindowOverlayChanged methods. r=jrmuizel,mattwoodrow

Depends on D52739

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbab3b7be092
Remove the prefs gfx.core-animation.enabled and gfx.compositor.glcontext.opaque, and all the code needed to support it. r=mattwoodrow,spohl
https://hg.mozilla.org/integration/autoland/rev/628967f53151
Remove now-unused DrawWindowOverlay and WindowOverlayChanged methods. r=mattwoodrow

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/fbab3b7be092
https://hg.mozilla.org/mozilla-central/rev/628967f53151

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.