1596248 - Simplify GLContext creation on macOS

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Markus Stange [:mstange]]

Now that we always render into IOSurfaces, we can simplify some code around GLContext creation on macOS.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Don't treat CompositorOGL coordinates differently in offscreen GL contexts. r=jgilbert

This code was trying to not render things upside down when rendering to offscreen contexts.
But this code path was never used and it wasn't fully working.
I would like to make our compositor contexts go through GLContextProviderCGL::CreateHeadless,
which creates an "offscreen" GLContext, so now this broken code is kicking in. Let's remove it.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Remove unused GLContextProvider::CreateForWindow. r=jgilbert

Depends on D52917

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Remove any notion of single or double buffered GLContexts. r=jgilbert

This distinction is not meaningful with CoreAnimation because all rendering happens into IOSurfaces.

Depends on D52918

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Remove the pref gl.require-hardware and instead just respect CreateContextFlags::FORCE_ENABLE_HARDWARE. r=jgilbert

This seems to be what other platforms do. FORCE_ENABLE_HARDWARE is controlled by the pref webgl.force-enabled.
gl.require-hardware was only read on macOS.

Depends on D52919

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Stop specifying depth buffer attributes when creating a GLContext for WebRender. r=jgilbert

This depth buffer would only be created for the default framebuffer, but there is
no default framebuffer on macOS (since all rendering goes into IOSurfaces), so
this attribute is ignored.
We already manually create depth buffers for the IOSurface framebuffers.

Depends on D52920

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Stop specifying depth buffer surface caps for WebRender. r=jgilbert

This setting was only respected for manually-created fake "default" framebuffers,
by code that no longer exists.

Depends on D52921

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Use CreateHeadless in GLContextProviderCGL::CreateForCompositorWidget. r=jgilbert

Depends on D52922

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Remove some duplicated checks, and the unused EMULATE_VM define. r=jgilbert

Depends on D52923

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1596248 - Add CreateContextFlags::PREFER_MULTITHREADED and change the pref name from gl to webgl. r=jgilbert

Depends on D52920

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a778da8ea81
Don't treat CompositorOGL coordinates differently in offscreen GL contexts. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/60f93190c588
Remove unused GLContextProvider::CreateForWindow. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/d332b04a1d99
Remove any notion of single or double buffered GLContexts. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/3bfe21f8500e
Remove the pref gl.require-hardware and instead just respect CreateContextFlags::FORCE_ENABLE_HARDWARE. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/442b6daa41ae
Add CreateContextFlags::PREFER_MULTITHREADED and change the pref name from gl to webgl. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/2fb40100f0fa
Stop specifying depth buffer attributes when creating a GLContext for WebRender. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/4fbfff4426f2
Stop specifying depth buffer surface caps for WebRender. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/827e48eb21a7
Use CreateHeadless in GLContextProviderCGL::CreateForCompositorWidget. r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/1b1fe528fa9b
Remove some duplicated checks, and the unused EMULATE_VM define. r=jgilbert,jrmuizel

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5a778da8ea81
https://hg.mozilla.org/mozilla-central/rev/60f93190c588
https://hg.mozilla.org/mozilla-central/rev/d332b04a1d99
https://hg.mozilla.org/mozilla-central/rev/3bfe21f8500e
https://hg.mozilla.org/mozilla-central/rev/442b6daa41ae
https://hg.mozilla.org/mozilla-central/rev/2fb40100f0fa
https://hg.mozilla.org/mozilla-central/rev/4fbfff4426f2
https://hg.mozilla.org/mozilla-central/rev/827e48eb21a7
https://hg.mozilla.org/mozilla-central/rev/1b1fe528fa9b