Closed Bug 1576411 Opened 6 years ago Closed 6 years ago

Port |Bug 1326910 - wait for a loadend event before using the width and height of the Page Info media preview| to SeaMonkey

Categories

(SeaMonkey :: Page Info, defect)

Product:
SeaMonkey
Component:
Page Info
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed, seamonkey2.63 wontfix)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed
seamonkey2.63 --- wontfix

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(1 file, 2 obsolete files)

loadend event patch v1.2
9.51 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Port following:

  • Bug 1326910 - wait for a loadend event before using the width and height of the Page Info media preview
Attached patch loadend event patch (obsolete) — — Splinter Review

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: image sizes can show incorrectly in page info
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Tested on a few sites (where we have seen issues before), not spotted any zero dimensions or images not showing in page info

Attachment #9087960 - Flags: review?(frgrahl)
Attachment #9087960 - Flags: approval-comm-release?
Attachment #9087960 - Flags: approval-comm-esr60?
Attached patch loadend event patch v1.1 (obsolete) — — Splinter Review

Remove unneeded code snippet

Attachment #9087960 - Attachment is obsolete: true
Attachment #9087960 - Flags: review?(frgrahl)
Attachment #9087960 - Flags: approval-comm-release?
Attachment #9087960 - Flags: approval-comm-esr60?
Attachment #9094455 - Flags: review?(frgrahl)
Attachment #9094455 - Flags: approval-comm-release?
Attachment #9094455 - Flags: approval-comm-esr60?

Remove unneeded var definition and inline.

Attachment #9094455 - Attachment is obsolete: true
Attachment #9094455 - Flags: review?(frgrahl)
Attachment #9094455 - Flags: approval-comm-release?
Attachment #9094455 - Flags: approval-comm-esr60?
Attachment #9094721 - Flags: review?(frgrahl)
Attachment #9094721 - Flags: approval-comm-release?
Attachment #9094721 - Flags: approval-comm-esr60?
Comment on attachment 9094721 [details] [diff] [review] loadend event patch v1.2 lgtm r/a+
Attachment #9094721 - Flags: review?(frgrahl)
Attachment #9094721 - Flags: review+
Attachment #9094721 - Flags: approval-comm-release?
Attachment #9094721 - Flags: approval-comm-release+
Attachment #9094721 - Flags: approval-comm-esr60?
Attachment #9094721 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6efcd4165414
Port Bug 1326910 "wait for a loadend event before using the width and height of the Page Info media preview" to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: